-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a utility to set the ssl library's MT hooks. #527
Conversation
WiSo, sorry about the miss-ping (if you check). @wsoltys is who I meant. ^^ |
hehe, WiSo = wsoltys so you pinged me twice ;) |
I've added the missing headers but getting unresolved external symbols for _CRYPTO_set_locking_callback and _CRYPTO_set_id_callback. To resolve them I would need the ssl import lib which fits to the ssl dll used by the third party build of libcurl which we don't have. |
Worth, noting: http://thread.gmane.org/gmane.comp.video.ffmpeg.cvs/43425 |
so we don't need any changes on win32. If worth I can change to a newer version of libcurl which uses openssl 1.0.0 |
If that's the case I'm going to simply add a destructor to clean up the locks then check this in. Is everyone Ok with that? |
what a bloody mess. pull is fine with me. |
We should do as done in that ffmpeg commit, only set the thread id for older versions. |
I'm fine with this. Are you sure this works properly with libcurl-gnutls? I'm not that familar with the internals of this... |
@arnova, I copied the code from an example and on my system HAVE_GCRYPT is true and it executes. I'm not sure how else to verify it since it's used indirectly anyway. |
status on this pull/req ? I've been seeing reports of hangs and bt logs that point to libcrypto.0.9.8.dylib 0x0276a6b8 lh_insert + 152 |
I have a code change that includes a simplification and cleanup (previous to this the locks don't get cleaned up) I didn't get a chance to check in this weekend. I'll do it shortly. |
Ok, one more review would help. |
Ok, I'm putting this in. Please let me know if it addresses the problems we've been seeing. |
Added a utility to set the ssl library's MT hooks.
TVDB update and fixes
This should fix the MT problems with libraries that use SSL. Namely, libcurl. It sets openssl and/or gcrypt locking hooks. It expects gcrypt to be used only on LINUX like machines.
Currently the Windows implementation is missing (at least) the openssl header file(s).
@wiso, can you let me know what I need to do to get openssl/crypto.h installed on windows? We apparently already have the dll.