Android StageFright and MediaCodec HEVC hw accel #5374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks ok, I don't have RK3288 based Android players. |
|
@jstebbins can you combine the cosmetics commit into the other commits? |
|
I should get a rk3288 from Rockchip next week, so I'll be able to test On 17 October 2014 08:19, Martijn Kaijser notifications@github.com wrote:
|
| // valid hvcC data (bitstream) always starts with the value 1 (version) | ||
| if(m_to_annexb) | ||
| { | ||
| if ( in_extradata[0] == 1 ) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@MartijnKaijser, sure will squash cosmetics today sometime, been unplugged for a few days :) |
|
small nudge |
|
cosmetics combined |
MartijnKaijser
added
v15 Isengard
Type: Feature
|
@jstebbins Could you rebase for inclusion, please |
|
Nevermind. Did it myself in #6034. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for HW HEVC decoding on Android
StageFright decoding works for me on an RK3288 based Android player.
MediaCodec fails with an IllegalStateException during MediaCodec::configure. I have not been able to track down the root cause of this. It could just be a problem with MediaCodec on my platform, but any pointers for debugging would be appreciated.