Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AML] HEVC, S805 and S812 board support #5533

Closed
wants to merge 4 commits into from
Closed

[AML] HEVC, S805 and S812 board support #5533

wants to merge 4 commits into from

Conversation

Stane1983
Copy link
Contributor

This PR depends on #5374 (needs BitstreamConverter patch for HEVC).

HEVC using AMLCodec is working on all sample files I could get. Need more interested testers :)

Also, I did not change h264 way of using bitstreamconverter for now, not to mess anything.

@koying @davilla

@koying
Copy link
Contributor

koying commented Oct 19, 2014

See #5493
We don't need the amlogic stuff. I've added a note in #5374 re some special case.

if (m_bitstream)
int demuxer_bytes = iSize;
uint8_t *demuxer_content = pData;
if (m_bitstream && !m_hevc)

This comment was marked as spam.

@Stane1983
Copy link
Contributor Author

As I wrote that I didn't change way of using bitstreamconverter for h264.. m_hevc is true only if we're going to decode HEVC, and if we do, then I use bitstream converting from #5374 , otherwise I'm using existing bitstream converting (or I'm missing something?)

@koying
Copy link
Contributor

koying commented Oct 19, 2014

Not sure I follow you. #5374 is implementing bitstream for both h264 & h265.
You put the result of conversion in demuxer_content then just forget about it ;)

@Stane1983
Copy link
Contributor Author

Yeah, sorry, will fix it lol :) But I still think AMLCodec hevc implementation is better. I merged patches from PR you mentioned. I have playback same as before (amcodec disabled), but seek makes video shuttering and a/v is OOS.

@koying
Copy link
Contributor

koying commented Oct 19, 2014

Well, use one or the other, not both ;)

@Stane1983
Copy link
Contributor Author

Same issues with both enabled separately. libstagefright and MediaCodec - shuttering, audio not synced with video. amcodec works good :)

@koying
Copy link
Contributor

koying commented Oct 19, 2014

Ah sorry, you meant the other codecs. Sure, no question amlcodec will be better...
When I refer to #5374, I only mean the bitstream conversion part...

@Hedda
Copy link
Contributor

Hedda commented Oct 20, 2014

Is this dependent on #5129 (Recognize AML Meson8 baby platform)?

@Stane1983
Copy link
Contributor Author

No

On Mon, Oct 20, 2014 at 1:56 PM, Hedda notifications@github.com wrote:

Is this dependent on #5129 #5129
(Recognize AML Meson8 baby platform)?


Reply to this email directly or view it on GitHub
#5533 (comment).

@koying
Copy link
Contributor

koying commented Nov 12, 2014

@Stane1983 Do you mind aligning hevc support with #5493, please
Works very fine for me, we don't need the bitstream stuff from amlogic

@Stane1983
Copy link
Contributor Author

Better? :)

@@ -775,6 +785,58 @@ int write_av_packet(am_private_t *para, am_packet_t *pkt)
}

/*************************************************************************/

static int check_size_in_buffer(unsigned char *p, int len)

This comment was marked as spam.

@topfs2 topfs2 added v15 Isengard and removed Helix labels Nov 12, 2014
@topfs2
Copy link
Contributor

topfs2 commented Nov 12, 2014

I think defering this to I* might be good. @koying if your happy with it you can change it back with some reasons as to why we shouldn't (stuff to ease my sleep ideally :P)

@koying
Copy link
Contributor

koying commented Nov 12, 2014

Well, there's very limited risks and we'd be trailing clones for 1 year on this.
OTOH, it's obviously a feature.

Up to you.

@MartijnKaijser
Copy link
Member

@Stane1983 can you rebase and update according to comments?

@koying
Copy link
Contributor

koying commented Dec 27, 2014

Superseeded by merged #5493

@Stane1983 Stane1983 deleted the aml-hevc branch August 30, 2015 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants