-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AML] HEVC, S805 and S812 board support #5533
Conversation
if (m_bitstream) | ||
int demuxer_bytes = iSize; | ||
uint8_t *demuxer_content = pData; | ||
if (m_bitstream && !m_hevc) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
As I wrote that I didn't change way of using bitstreamconverter for h264.. m_hevc is true only if we're going to decode HEVC, and if we do, then I use bitstream converting from #5374 , otherwise I'm using existing bitstream converting (or I'm missing something?) |
Not sure I follow you. #5374 is implementing bitstream for both h264 & h265. |
Yeah, sorry, will fix it lol :) But I still think AMLCodec hevc implementation is better. I merged patches from PR you mentioned. I have playback same as before (amcodec disabled), but seek makes video shuttering and a/v is OOS. |
Well, use one or the other, not both ;) |
Same issues with both enabled separately. libstagefright and MediaCodec - shuttering, audio not synced with video. amcodec works good :) |
Ah sorry, you meant the other codecs. Sure, no question amlcodec will be better... |
Is this dependent on #5129 (Recognize AML Meson8 baby platform)? |
No On Mon, Oct 20, 2014 at 1:56 PM, Hedda notifications@github.com wrote:
|
@Stane1983 Do you mind aligning hevc support with #5493, please |
Better? :) |
@@ -775,6 +785,58 @@ int write_av_packet(am_private_t *para, am_packet_t *pkt) | |||
} | |||
|
|||
/*************************************************************************/ | |||
|
|||
static int check_size_in_buffer(unsigned char *p, int len) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I think defering this to I* might be good. @koying if your happy with it you can change it back with some reasons as to why we shouldn't (stuff to ease my sleep ideally :P) |
Well, there's very limited risks and we'd be trailing clones for 1 year on this. Up to you. |
@Stane1983 can you rebase and update according to comments? |
Superseeded by merged #5493 |
This PR depends on #5374 (needs BitstreamConverter patch for HEVC).
HEVC using AMLCodec is working on all sample files I could get. Need more interested testers :)
Also, I did not change h264 way of using bitstreamconverter for now, not to mess anything.
@koying @davilla