Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Confluence] recently added albums on home #543

Closed
wants to merge 1 commit into from

Conversation

mad-max
Copy link
Contributor

@mad-max mad-max commented Nov 22, 2011

Basically this code was written because of a user-request in the forums...
As it was done, I thought I could share it...
I think Jezz would call it: "to make it consistent" ;-)
So maybe you are interested and want to pull...

cheers,
mad-max

@ghost ghost assigned JezzX Mar 26, 2012
@JezzX
Copy link
Contributor

JezzX commented Mar 29, 2012

Just so you know I'm not ignoring this I have read this from the start :0 and I will add in this functionality I just don't think I will be using this pull request directly.

Reasons are you did a great job of doing the heavy lifting but the alignment was not quite right for me (picky I know). The album icons were too large and the height of boxes were bigger than the height of Movies and Episode ones (I know I'm being real Picky)

You also reused the same control id for them that Episodes had and that caused a little issue when I fix another issue on trac http://trac.xbmc.org/ticket/12851.

The other issue is whats the teams opinion on reusing labels so soon? while its fine for English all the other languages will have the wrong text already translated and not know if they need to change it. Anybody else got an opinion on that ?

Anyway with all those seemingly negative comments aside you basically did about 90% of the work and I just tweaked it to how I wanted so thanks for giving me a kick in the butt too do so.

I'll leave this request open a little until people comment on the translation stuff,
Ignore the other changes in this screenshot here is the one I did that I'll put back in main soon http://i44.tinypic.com/2q8vwnb.png

@mad-max
Copy link
Contributor Author

mad-max commented Mar 29, 2012

Being picky is not a problem for me as I know that the job will be done with 110% passion ;-)

I'm glad I could help out a bit and prepare this for you...
And I have to agree about the translation. Picking a new string would have been a better solution here...

BTW: The changes beside the recently added albums are looking really good, especially the blue with the focused entry in home

@mad-max
Copy link
Contributor Author

mad-max commented Apr 6, 2012

closed in favor of #857

@mad-max mad-max closed this Apr 6, 2012
FernetMenta referenced this pull request in FernetMenta/xbmc Jun 15, 2012
HolgerW1 pushed a commit to HolgerW1/xbmc that referenced this pull request Sep 26, 2014
AddNewShow tvdb_api languages select fixed (would only contain the fallback 'en')
@mad-max mad-max deleted the recentlyadded branch March 3, 2015 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants