-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect parent path decision when cleaning paths. #5524
Conversation
When cleaning the video library and a source containing TV shows was unavailable, choosing to keep it only kept the source root, while subdirectories were removed. The result was that TV shows "disappeared". This is fixed by checking if there's a decision for the parent path when cleaning the path table.
If that does, what I think it does, it has my +1 but needs @Montellese for review. Thanks anyways for improving xbmc. |
I think this looks ok but I'm not sure if it will always work. I think it only works under the assumption that the directory structure is PS: I'm working on some additional logic that should better handle sources on unavailable machines as well but didn't know this was an issue. |
I've just tested this
Can you suggest a different structure where you think this wouldn't work? Edit: note that the query only SELECTs the TV show subdirectory, after that you can have whatever you want:
In current master 74 is kept, but 75 is removed. |
Sorry, forgot about this one. Should be good to go in @topfs2 @MartijnKaijser. |
jenkins build and merge |
When cleaning the video library and a source containing TV shows was unavailable,
choosing to keep it only kept the source root, while subdirectories were
removed.
The result was that TV shows "disappeared".
This is fixed by checking if there's a decision for the parent path when
cleaning the path table.
See: #5324 (comment)