Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dxva: fix selection of render target format #5531

Merged
merged 1 commit into from
Oct 21, 2014

Conversation

FernetMenta
Copy link
Contributor

fixes an issue I introduced with dxva refactoring. nv12 is preferred over yv12 and renderer may no suppport yv12 which can result in a segfault.

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@jjd-uk
Copy link
Member

jjd-uk commented Oct 19, 2014

This has fixed the issue I was having on my test pc, I tried all the combinations of render method and hardware decoding and all is perfect now. Thanks a lot FernetMenta.

@FernetMenta FernetMenta added Helix Type: Fix non-breaking change which fixes an issue labels Oct 19, 2014
@FernetMenta
Copy link
Contributor Author

this got a milestone tag but no approval so far. missed or intentional?

@MartijnKaijser
Copy link
Member

Well I'm not the one knowing the code best or even capable of saying approved. Just seeing this as a valid and tested fix. @topfs2.

FernetMenta added a commit that referenced this pull request Oct 21, 2014
dxva: fix selection of render target format
@FernetMenta FernetMenta merged commit f683137 into xbmc:master Oct 21, 2014
@FernetMenta FernetMenta deleted the winrender branch October 21, 2014 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants