[fix] keyboard layout default setting #5539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes to match xbmc#5525 setting name is now English QWERTY
MartijnKaijser
added a commit
that referenced
this pull request
Oct 20, 2014
[fix] keyboard layout default setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes empty OSK since #5525 setting name is now English QWERTY 馃憤
Because default name changed you would get no keys on OSK because list of keyboardlayout is now empty for those who had QWERTY as default and thus a empty OSK
I suppose if your keyboard layout was renamed (for e.g. Bulgarian/Russian) you need to reselect it again since it drops from the guisettings because no match if those were your default you also get empty osk until reselect layout.
But there is a remaining issue I dont know how to fix.
If a user happens to select no layouts at all you still get empty OSK, I would suggest that the fallback requires one otion to be selected in the list and not allow a user no layout selection.
Idk how to implement that so anyone else may need to step in after this.
@MartijnKaijser