[keyboard layouts] use English language names #5525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added small comment to guide future contributors.
topfs2
added
Helix
Type: Fix
|
@MartijnKaijser any thoughts? looks ok by me. This is the way we want it named no? |
MartijnKaijser
added a commit
that referenced
this pull request
Oct 18, 2014
[keyboard layouts] use English language names
un1versal
pushed a commit
to un1versal/kodi
that referenced
this pull request
Oct 20, 2014
This fixes to match xbmc#5525 setting name is now English QWERTY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This normalizes language names to English and specify English in QWERTY/ABC/AZERTY
_Future consideration_
In future because the OSK Button label is rather limited in length that a _ID_ field could be implemented So that _layout name_ would be displayed in selection list and in _id_ would show in button label something like.
However that last part (implementing the id) I would require assistance in the C++ portion @stefansaraev understands this idea.
@MartijnKaijser hope this helps the author of #5419 make up his mind and rebase/change his PR.