Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win32] fix some unit tests #5578

Merged
merged 4 commits into from
Oct 26, 2014
Merged

Conversation

Montellese
Copy link
Member

These commits fix the unit test setup and some unit tests on win32.

  • The first commit fixes building and running unit tests from Visual Studio.
  • The second commit silences a warning due to an unused variable (only used by non-win32 platforms)
  • The third commit fixes CXBMCTestUtils::ReferenceFilePath() which is used in a lot of places to get a valid path to a test file. It probably worked on non-win32 platforms but was broken on win32 due to putting together paths ending with \ and starting with /.
  • The last commit excludes TestRarFile from the unit test project for now because compilation fails due to 47f3d83 and I don't really know what the proper fix is. On win32 the missing S_IFLNK is never used in any core code only in the unit tests.

@Montellese Montellese added the Type: Fix non-breaking change which fixes an issue label Oct 26, 2014
@Memphiz
Copy link
Member

Memphiz commented Oct 26, 2014

Looks good for me - for the testrarfile either just define the missing S_IFLINK for the windows part in the cpp or revert the offender.

@Montellese
Copy link
Member Author

OK I have changed the last commit to define S_IFLNK if it isn't already defined.

@MartijnKaijser MartijnKaijser added this to the Helix 14.0-alpha5 milestone Oct 26, 2014
@Montellese
Copy link
Member Author

I started some manual jenkins builds with unit tests enabled:

When I run unit tests locally on win32 I still get a few failures but this fixes some of them and doesn't break other platforms.

MartijnKaijser added a commit that referenced this pull request Oct 26, 2014
@MartijnKaijser MartijnKaijser merged commit f256f53 into xbmc:master Oct 26, 2014
@Montellese Montellese deleted the fix_unittests branch October 26, 2014 23:06
@Memphiz
Copy link
Member

Memphiz commented Oct 27, 2014

Fyi - Unit Tests are not hooked up for win32 jenkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants