revert b6bec7a

[stefansaraev]

this reverts upstream commit b6bec7a (part of /pull/4761):

From b6bec7a Mon Sep 17 00:00:00 2001
From: Trent Nelson trent.nelson@pivosgroup.com
Date: Wed, 21 May 2014 17:16:54 +0800
Subject: [PATCH] [PVR] Make sure client addons are disabled first time we see
them.

/pull/4761 fixed a bug where newly added pvr clients were automaticaly
enabled and could not be disabled first time an user tries to disable em.

unfortunately, it introduces a regression, now "reset pvr database" is useless
and leaves the user with no pvr clients enabled at all.

however, the "oh-i-can-not-disable-pvr-addons" bug I can not reproduce
anymore, but this commit may re-introduce it for some users.

for details on the regression please look at #4761 (comment)

I did not intend to PR this, but I've been asked to. please note that I am not a coder at all, this could be wrong as hell, but it fixes an annoying regression for me, IMO it's better to have an old bug (the annoying part of the old bug I can not reproduce anymore) than introducing new one..

ping @opdenkamp @t-nelson

[t-nelson]

I'm fairly certain reverting this is not the fix. @opdenkamp, I vaguely remember discussing this at some point and that there was some internal state that may need flushed at db wipe time?

[opdenkamp]

I'll take another look at it tomorrow, don't even have the tree checked
out atm ;-)

On 01-11-14 19:57, Trent Nelson wrote:

I'm fairly certain reverting this is not the fix. @opdenkamp
https://github.com/opdenkamp, I vaguely remember discussing this at
some point and that there was some internal state that may need
flushed at db wipe time?

—
Reply to this email directly or view it on GitHub
#5595 (comment).

[stefansaraev]

this is going nowhere and is unlikely to be merged. so closing