Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] don't reset internal group channel numbers if reset channel number cache #5867

Merged
merged 1 commit into from
Jan 5, 2015

Conversation

xhaggi
Copy link
Member

@xhaggi xhaggi commented Dec 2, 2014

Should fix the issue reported in Trac http://trac.kodi.tv/ticket/15563

When "use backend channel number" is selected in settings/live tv/general (using pvr.wmc client) infolabel Listitem.ChannelNumberLabel returns labels in the form "0.y" (y = minor channel number for US ATSC virtual channels) for all channels which are not members of the selected channel group (when "use backend channel number" is not selected, the infolabel returns "0"). Observed in Confluence Dialog PVRGroupManager.
Expected result would either be "0" for channels not in current channel group or "x.y" with the actual major.minor virtual channel number. Assumed source is PVRChannelGroupInternal.cpp.

@xhaggi xhaggi added Component: PVR Type: Fix non-breaking change which fixes an issue labels Dec 2, 2014
@opdenkamp
Copy link
Member

I'm not really comfortable with changing this at this point. I know that it was needed for something when I wrote it, but it was ~4 years ago and I don't remember why exactly.

Since it's not fixing a critical bug, it should wait until the first point release.

@xhaggi xhaggi closed this Dec 8, 2014
@xhaggi xhaggi deleted the pvr-fix-channel-numbering branch December 8, 2014 11:19
@xhaggi xhaggi restored the pvr-fix-channel-numbering branch January 5, 2015 10:37
@xhaggi xhaggi reopened this Jan 5, 2015
@xhaggi
Copy link
Member Author

xhaggi commented Jan 5, 2015

jenkins build this please

@xhaggi
Copy link
Member Author

xhaggi commented Jan 5, 2015

@opdenkamp ping

@opdenkamp
Copy link
Member

merge away, but as i said earlier, it was needed earlier, so if you run into issues when switching between groups, you know why ;-)

xhaggi added a commit that referenced this pull request Jan 5, 2015
[pvr] don't reset internal group channel numbers if reset channel number cache
@xhaggi xhaggi merged commit e8cd856 into xbmc:master Jan 5, 2015
@MartijnKaijser MartijnKaijser modified the milestone: Helix 15.0-alpha1 Jan 10, 2015
phil65 pushed a commit to phil65/xbmc that referenced this pull request Jan 10, 2015
[pvr] don't reset internal group channel numbers if reset channel number cache
@xhaggi xhaggi deleted the pvr-fix-channel-numbering branch February 23, 2015 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v15 Isengard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants