Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[settings.xml] - changed several spinners to lists #6176

Merged
merged 1 commit into from
Feb 28, 2015

Conversation

phil65
Copy link
Contributor

@phil65 phil65 commented Jan 10, 2015

like discussed some weeks ago, this changes several spinners to lists in settings.
Basically I left out:

  • spinners dealing with numbers and fixed step size
  • some settings which caused a delay until DialogSelect appears

@Montellese for review.

@Montellese
Copy link
Member

I don't really have a strong opinion on this. The changes are trivial.
There are a few settings which basically represent a tri-state (e.g. videolibrary.flattentvshows) which might work as a spinner as well. But like I said I'm not very good with UI/UX so I leave it to the people who know better.

@phil65
Copy link
Contributor Author

phil65 commented Jan 10, 2015

yeah it ´s more about an opinion than a review, that´s correct.
I will pick @ronie, @BigNoid, @da-anda as UI people then. :)
I would prefer a list instead of a spinner also for 3-state-buttons.

@BigNoid
Copy link
Member

BigNoid commented Jan 11, 2015

+1, this is an improvement on usability. Are videoplayer.stereoscopicplaybackmode and videoscreen.screen too slow to convert to spinners or did you miss those?

@ronie
Copy link
Member

ronie commented Jan 11, 2015

+1 for the exact same reason as @BigNoid
this drastically improves usability.

@phil65
Copy link
Contributor Author

phil65 commented Jan 11, 2015

@BigNoid : yes, I think both were too slow. Perhaps you can try out if it is the same on your machine.

@da-anda
Copy link
Member

da-anda commented Jan 12, 2015

will check/review once I'm fully recovered from vacation - but in general +1 on anything that improves UX

@tamland
Copy link
Member

tamland commented Feb 26, 2015

Any plans merging this? The spinners are so annoying..

@Montellese Montellese added the Type: Improvement non-breaking change which improves existing functionality label Feb 26, 2015
@Montellese Montellese added this to the I******* 15.0-alpha2 milestone Feb 26, 2015
@Montellese Montellese self-assigned this Feb 26, 2015
Montellese added a commit that referenced this pull request Feb 28, 2015
[settings.xml] -  changed several spinners to lists
@Montellese Montellese merged commit 8bc58f4 into xbmc:master Feb 28, 2015
@phil65 phil65 deleted the settings_xml branch December 18, 2016 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants