[cec] make libCEC a bit more silent

[opdenkamp]

• removed unneeded kaitoast
• ask if the user wants to disable CEC if no CEC capable TV was found for 30 seconds

@popcornmix this should address your log spam issues on setups that don't have CEC

[opdenkamp]

jenkins build this please

[ksooo]

@opdenkamp Yeah! Had that "no kaitoast on config change" patch for ages on my private kodi build. :-)

[MilhouseVH]

This may be an OpenELEC/Kodi15 issue, but having selected "Yes" to the dialog (as my monitor isn't CEC capable), when the settings are saved on shutdown[1] the peripheral_data/rpi_2708_1001.xml file is being written out with CEC still enabled, shouldn't it be disabled?

    <setting id="enabled" value="1" />

Consequently, the user is prompted again next time they boot. And the next time. And the next time, etc., until they manually disable CEC in Settings -> System -> Input devices.

I'm testing with a completely fresh .kodi folder (rm -fr .kodi etc.) so all settings are default (testing build #0329).

1. Recent OpenELEC/Kodi15 test builds do have a problem saving settings on GUI shutdown/reboot, but settings are successfully saved (and peripheral_data/rpi_2708_1001.xml created) with systemctl stop kodi

[MilhouseVH]

Further to my previous comment, OpenELEC is now correctly saving settings on shutdown but this dialog is still prompting every boot and doesn't appear to be saving the setting chosen by the user. This change is actually causing more noise than without.

http://forum.kodi.tv/showthread.php?tid=224025&pid=1985812#pid1985812

[opdenkamp]

right, will check after the libCEC bump got merged and fix it

[MilhouseVH]

Hi, just confirming that this issue is still there with latest libCEC 3.0.0 (4c9c197) and an OpenELEC Kodi master test build.

1. Enable CEC in Peripherals when connected to a computer monitor without CEC capability
2. Reboot Pi
3. When Pi has restarted, after a short delay the prompt "CEC not detected, disable?" appears
4. Click on "Yes" to disable further polling
5. Go to Setings -> Input devices -> Peripherals -> CEC
6. Confirm that CEC is still marked as "Enabled"
7. Go to 2.

Every boot the user is prompted to disable CEC polling, until they eventually disable CEC permanently via Settings -> Input devices -> Peripherals -> CEC -> Disable.

Of course I'm assuming that answering "Yes" to the "Disable polling?" prompt should permanently disable CEC from that point onwards, for the current boot and future boots. If that isn't the case then I'm really not sure what advantage/benefit this change brings, and will surely become very annoying for those users that don't have a CEC enabled TV! :)

[meikelmoeller]

I am running Isengard beta on my RPi2. The raspberry is connected through my AVR (CEC capable) with an Optoma beamer without CEC capabilities. In Helix it is no problem to switch the AVR on/off by CEC signal from the RPi2.
How can I disable the popup message. "No CEC capable TV Detected"?
I don´t want to disable CEC!

[opdenkamp]

right, it can't be disabled now and most people seemed to want to have it disabled, but that's more because of the logging spam caused while libCEC is polling things. I guess another solution would be to just silence libCEC's logging if nothing was found X seconds after startup.

[meikelmoeller]

THX for the response. The main feature what I want is adjusting the AVR volume with the Raspberry. When only the CEC feature is enabled and the other points are deactivated, the function is given. Thats what I want and I rolled back to Helix because the popup appears every system boot with Isengard.

[opdenkamp]

right, unfortunately that's undefined behaviour in the spec without a TV that supports CEC, though I bet that it often just works. I'll put it on the list for after cleaning up the platform/kodi-platform mess

[ksooo]

My HTPC is starting up at every night automatically in order to do certain things, but the (CEC-capable) TV and AVR are physically turned off at this time. This worked just fine before, but now it leads to the abovementioned dialog every time, because ofc I do not want to disable CEC.