[rbp/mmal] A collection of MMAL fixes from newclock4 #6961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bad things happen when submitting a buffer to renderer twice. We were attempting to protect against that with a flip count. However that was getting reset from AddProcessor, the the sequence: Decode->AddProcessor->RenderUpdate->AddProcessor->RenderUpdate could occur. Instead use a bit from the MMAL flags which is unlikely to get out of sync with the MMAL buffer.
When switching rapidly between different files you sometimes ended up with a stale buffer
popcornmix
force-pushed
the
mmal_updates
branch
from
d30b437
to
93b15fa
Compare
|
jenkins build this please |
popcornmix
added a commit
that referenced
this pull request
Apr 17, 2015
[rbp/mmal] A collection of MMAL fixes from newclock4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submitting buffers twice and reset of m_buffers on PreInit are proper crash and burn bugs.
The fast deinterlace change saves two frame buffers (6M) in some circumstances.
The resolution change makes resolution changes cleaner.
Others are just tidy-ups.