videodb: add a delete trigger for the files table #6972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montellese
added
the
Type: Improvement
|
+1 Thanks. |
|
jenkins build and merge |
|
@Montellese do we need a database version bump? |
Montellese
force-pushed
the
videodb_files_delete_trigger
branch
from
64730cd
to
1e89519
Compare
|
@xhaggi: Thanks for the reminder. Forgot to cherry-pick that one. |
|
jenkins build and merge |
|
Wouldn't ON DELETE CASCADE be more suitable? |
|
there is no cascading in MySQL MyISAM only InnoDB. if we force innodb then we could use it instead of delete trigger, but keep in mind we need foreign key constraints. |
|
First of all I'm not a fan of CASCADE because you loose absolute control over what is happening. Secondly (as already explained by @xhaggi) it's not supported everywhere and we don't have any explicit foreign key contraints etc. |
|
OSX build error is unrelated. Any objections? |
|
Fine by me |
Montellese
added a commit
that referenced
this pull request
Apr 18, 2015
videodb: add a delete trigger for the files table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an SQL trigger for deletes on the
filestable so that we don't have to remember to clean up all those other tables that have a foreign key on thefilestable. Right now there's only one place but there'll be others in the future (in some of my work) and since it doesn't hurt adding it already I thought I put up a PR.