Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMX] probe & push all resolutions we can use #6996

Merged
merged 1 commit into from
May 1, 2015
Merged

[IMX] probe & push all resolutions we can use #6996

merged 1 commit into from
May 1, 2015

Conversation

mk01
Copy link
Contributor

@mk01 mk01 commented Apr 20, 2015 

  beside standard(S), try also DVI(U), VESA(V)

  • try in order S -> U -> V

  • don't add modes with resolution & refresh we alredy have

  • S are preferred (over other types with same XxYxR) because
    they come from EDID(CEA) and do pass requirements
    for proper hdmi audio out

    (this superseeds sam's PR and was rediscussed with
    fritsch on IRC. also please see code comments around
    m_init and fPixelRatio calculation)

@fritsch
Copy link
Member

fritsch commented Apr 20, 2015

Thanks much. As discussed on IRC +1

For @koying to review.

koying
koying reviewed Apr 21, 2015
View reviewed changes
xbmc/windowing/egl/EGLNativeTypeIMX.cpp
// recalculated PR relatively to startup desktop resolution will result in 1.0f
// for all res with same AR and allows use of others without need to calibrate before
// by user.
res->fPixelRatio = (float)m_init.fPixelRatio / (res->iScreenWidth/res->iScreenHeight);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@fritsch
Copy link
Member

fritsch commented Apr 24, 2015

@mk01 please update to the version with EDID parsing, please

@fritsch
Copy link
Member

fritsch commented Apr 27, 2015

Thanks much

@koying: good to go?

@mk01
[IMX] probe & push all resolutions we can use
31e87e2 
      beside standard(S), try also DVI(U), VESA(V)

 - try in order S -> U -> V
 - don't add modes with resolution & refresh we alredy have
 - S are preferred (over other types with same XxYxR) because
   they come from EDID(CEA) and do pass requirements
   for proper hdmi audio out

 (this superseeds sam's PR and was rediscussed with
  fritsch on IRC.)
@koying
Copy link
Contributor

koying commented May 1, 2015

+1

@fritsch fritsch added the Type: Fix non-breaking change which fixes an issue label May 1, 2015
@fritsch
Copy link
Member

fritsch commented May 1, 2015

jenkins build and merge (build only to see if nothing else broke by accident)

@MartijnKaijser
Copy link
Member

you know you are now directly merging this right?

@fritsch
Copy link
Member

fritsch commented May 1, 2015

Yes - as it fixes a bug and the maintainer / author of this code acked it. Furthermore it makes IMX working on AVRs that only send U modes.

Besides that I think the jenkins trigger failed.

jenkins4kodi added a commit that referenced this pull request May 1, 2015
@jenkins4kodi
Merge pull request #6996 from mk01/master
1de18d9
@jenkins4kodi jenkins4kodi merged commit 1de18d9 into xbmc:master May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Fix non-breaking change which fixes an issue
Projects
None yet
Milestone
Isengard 15.0-beta1
Development

Successfully merging this pull request may close these issues.
5 participants
@mk01 @fritsch @koying @MartijnKaijser @jenkins4kodi