[Webdav]: Native Exists() and Stat() functions #7073
Conversation
|
@mkortstiege : Please comment/review. Note that I needed to change CCurlFile a bit to avoid logspam. |
|
jenkins build this please |
arnova
force-pushed
the
webdav_propfind
branch
2 times, most recently
from
584b9c6
to
0366fa7
Compare
|
jenkins build this please |
|
jenkins build this please |
|
jenkins build this please |
|
jenkins build this please because github was down earlier today |
arnova
force-pushed
the
webdav_propfind
branch
16 times, most recently
from
ecf19ff
to
7a0346a
Compare
|
ping @mkortstiege . After some more reading it seems we might as well use the HEAD method for exists/stat, also seems a bit more efficient since less data is transferred. I think we do still want the improvements in CCurlFile. |
|
Looks and sounds good to me. Would like to get another +1 so we can shove this in for next beta to get some more testers on it. |
|
I like the changes but it will be a change in behaviour so I don't think it should go in during Isengaard. |
|
@Paxxi: The Curl changes are pretty safe and currently we hammer (retry) on 404 which is not nice. I'd propose the keep this PR on hold and in the meantime I'll open a new one which only has the Curl changes. |
|
I agree @arnova you have my +1 for merging those :) |
|
jenkins build and merge |
|
@MartijnKaijser : You probably misread the discussion in this PR. But this shouldn't have been merged (yet). And apparently it's causing crashes, so I think for now it would be best to revert until we've fixed the crash and we're sure there's an actual benefit from this. |
Previously we used plain http methods for Webdav file Exists/Stat, and although it works (most of the time), it is wrong and may not work properly with all clients. This PR implements the proper native functions.