[Libcurl] 404 fix + misc. tweaks #7137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2015 18:26
|
looks good |
|
+1 feel free to merge |
|
jenkins build this please and merge |
|
I think it won't merge :-) |
MartijnKaijser
added a commit
that referenced
this pull request
May 15, 2015
[Libcurl] 404 fix + misc. tweaks
yol
reviewed
Mar 29, 2018
| // Check response code | ||
| long response; | ||
| if (CURLE_OK == g_curlInterface.easy_getinfo(m_easyHandle, CURLINFO_RESPONSE_CODE, &response)) | ||
| return response; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the "safe" fixes from #7073 . It mainly fixes an issue where we hammer remote servers when getting a 404. Furthermore we should only retry without range set when we encounter an actual http range-error, not all http-errors.