Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[strings] take 2 - fix capitalized second/third word + fix typos/misspelling and cleanup. #7080

Merged
merged 2 commits into from
May 10, 2015
Merged

[strings] take 2 - fix capitalized second/third word + fix typos/misspelling and cleanup. #7080

merged 2 commits into from
May 10, 2015

Conversation

un1versal
Copy link
Contributor

Similar to #7054 but on resource.language.en_gb

@MartijnKaijser @jjd-uk @Jalle19

Second commit could be squashed, was done separately as it contained the typos / misspeling
and other non capitalization fixes.

May have missed one or other instances (eyes gone after a while).

Please indicate which lines to fix on review comments.
@Jalle19 if you feel like parting with your excellent review skills.

unused strings were considered but I think it needs some deeper research so left them out at this time.

@un1versal un1versal force-pushed the strings branch 3 times, most recently from c99d25e to b8f6147 Compare May 7, 2015 11:38
@un1versal un1versal changed the title [strings] capitalized second/third word [strings] Take 2 - fix capitalized second/third word May 7, 2015
@un1versal un1versal changed the title [strings] Take 2 - fix capitalized second/third word [strings] take 2 - fix capitalized second/third word May 7, 2015
@un1versal un1versal mentioned this pull request May 7, 2015
Closed
@un1versal un1versal changed the title [strings] take 2 - fix capitalized second/third word [strings] take 2 - fix capitalized second/third word + fix typos/misspelling and cleanup. May 7, 2015
MartijnKaijser
MartijnKaijser reviewed May 8, 2015
View reviewed changes
addons/resource.language.en_gb/resources/strings.po
@@ -16412,7 +16412,7 @@ msgstr ""
#. Description of setting #14102 Settings -> Video -> Discs -> Blu-ray playback mode
#: system/settings/settings.xml
msgctxt "#37031"
msgid "Specifies how Blu-rays should be opened/played back. Disc menus are not fully supported yet and may cause problems."
msgid "Specifies how Blu-ray's should be opened/played back. Disc menus are not fully supported yet and may cause problems."

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

da-anda
da-anda reviewed May 8, 2015
View reviewed changes
addons/resource.language.en_gb/resources/strings.po
@@ -8646,7 +8646,7 @@ msgid "The PVR manager has been enabled without any"
msgstr ""

msgctxt "#19242"
msgid "enabled PVR Add-on. Enable at least one Add-on"
msgid "enabled PVR add-on. Enable at least one add-on"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

da-anda
da-anda reviewed May 9, 2015
View reviewed changes
addons/resource.language.en_gb/resources/strings.po
@@ -3608,7 +3608,7 @@ msgid "Singles"
msgstr ""

msgctxt "#1051"
msgid "Enter web address"
msgid "Enter Web address"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@un1versal
Copy link
Contributor Author

Right all instances of All seasons and Specials are now "quoted" consistently and resemble the entries they refer to in main skin areas. This means that they must be handled the same way without exception in every sentence.

Did I miss anything so far? Anymore for anymore?

@da-anda
Copy link
Member

da-anda commented May 9, 2015

only checked the diff on Github but looks good IMO

@un1versal
Copy link
Contributor Author

One more... internet -> Internet

http://en.wikipedia.org/wiki/Internet
https://encrypted.google.com/search?q=define+internet
http://www.oxforddictionaries.com/definition/english/Internet

👅 👍

Much polemic about this.... it is a proper noun, so, therefore.

@un1versal
Copy link
Contributor Author

Right. Web is now web.

Also....

Because there were a few different usages around Web server vs Webserver, Neither is wrong but mixing them isn't great.
They are all now consistent.

Beginning of sentence:

Web server

Middle of sentence.

bla bla bla web server bla bla bla

I opted by splitting the words due to some main entries were already split, and they are main entries!!

However in case someone feels strongly about this, I can make them all one word throughout. its either one or the other, both wont do.

Also had a clean-up with the brackets and spacing around VDPAU VAAPI etc, again most entries are not in brackets elsewhere and its either all one way or the other way.

When this is merged, Ill have a cleanup around unused strings (the obvious ones)

Anymore for anymore?

@phil65
Copy link
Contributor

phil65 commented May 9, 2015

looks fine now IMO. thx.

@un1versal un1versal force-pushed the strings branch 4 times, most recently from 4b9b7c9 to 4871f37 Compare May 9, 2015 22:48
MartijnKaijser
MartijnKaijser reviewed May 10, 2015
View reviewed changes
addons/resource.language.en_gb/resources/strings.po
@@ -16306,7 +16306,7 @@ msgstr ""

#: xbmc/cores/dvdplayer/DVDInputStreams/DVDInputStreamNavigator.cpp
msgctxt "#37002"
msgid "(Directors Comments 2)"
msgid "(Directors comments 2)"

This comment was marked as spam.

Sign in to view

da-anda
da-anda reviewed May 10, 2015
View reviewed changes
addons/resource.language.en_gb/resources/strings.po
@@ -15977,7 +15977,7 @@ msgstr ""
#. name of a stereoscopic mode
#: system/settings/settings.xml
msgctxt "#36509"
msgid "Monoscopic (2D)"
msgid "Monoscopic - 2D"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@un1versal un1versal force-pushed the strings branch 3 times, most recently from 337584d to 6b152ba Compare May 10, 2015 09:44
MartijnKaijser added a commit that referenced this pull request May 10, 2015
@MartijnKaijser
Merge pull request #7080 from uNiversaI/strings
701c0e4 
[strings] take 2 - fix capitalized second/third word + fix typos/misspelling and cleanup.
@MartijnKaijser MartijnKaijser merged commit 701c0e4 into xbmc:master May 10, 2015
MartijnKaijser added a commit to MartijnKaijser/xbmc that referenced this pull request May 10, 2015
@MartijnKaijser
Merge pull request xbmc#7080 from uNiversaI/strings
200af2e 
[strings] take 2 - fix capitalized second/third word + fix typos/misspelling and cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Isengard 15.0-beta2
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@un1versal @da-anda @phil65 @Montellese @MartijnKaijser @wsnipex @ksooo