[strings] fix capitalized second/third word #7054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jjd-uk are you OK with this? |
un1versal
force-pushed
the
patch-2
branch
3 times, most recently
from
3f792d1
to
324fa35
Compare
| @@ -235,7 +235,7 @@ msgstr "" | |||
| #empty strings from id 31113 to 31115 | |||
|
|
|||
| msgctxt "#31116" | |||
| msgid "Show Recently added Albums" | |||
| msgid "Show recently added Albums" | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The newer string are correct, however older strings suffer from this issue. Exceptions where left as is: * Words after : (colon) * Category names https://github.com/uNiversaI/kodi/blob/f5f938e428a3a81c957b2d934a73c168280846ca/addons/skin.confluence/language/English/strings.po#L237-L243 * CAPITALIZED long srings https://github.com/uNiversaI/kodi/blob/f5f938e428a3a81c957b2d934a73c168280846ca/addons/skin.confluence/language/English/strings.po#L508-L532#
|
@Jalle19 thx, was unsure about those you mentioned due to context. Better in any case:+1: |
|
Looks ok to me |
MartijnKaijser
added a commit
that referenced
this pull request
May 6, 2015
[strings] fix capitalized second/third word
un1versal
pushed a commit
to un1versal/kodi
that referenced
this pull request
May 7, 2015
un1versal
pushed a commit
to un1versal/kodi
that referenced
this pull request
May 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the newer string are correct but older strings still have this issue.
Only exception is lines like e.g. 148 or 517
May have missed one or other instances. please indicate which lines to fix on review comments.
@MartijnKaijser