Fixed OS X i386 Xcode builds on x86_64 build machines #7085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without assigning App-OSX.xcconfig to Kodi.app target building i386 target will not fix dependent libraries when bundling the Kodi.app with copyframeworks-osx.command copyframeworks-osx.command uses XBMC_DEPENDS that composed like $(XBMC_DEPENDS_ROOT)/$(SDK_NAME)_$(CURRENT_ARCH)-target CURRENT_ARCH not set correctly, without assigning App-OSX.xcconfig the ONLY_ACTIVE_ARCH is not set and the builder machine architecture will be used instead of the targeted architecture.
|
thx jenkins build and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without assigning App-OSX.xcconfig to Kodi.app target building i386
target will not fix dependent libraries when bundling the Kodi.app with
copyframeworks-osx.command
copyframeworks-osx.command uses XBMC_DEPENDS that composed like
$(XBMC_DEPENDS_ROOT)/$ (SDK_NAME)_$(CURRENT_ARCH)-target
CURRENT_ARCH not set correctly, without assigning App-OSX.xcconfig the
ONLY_ACTIVE_ARCH is not set and the builder machine architecture will
be used instead of the targeted architecture.