-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added: hide thumbs for unwatched episodes option to show plot is off #7462
Conversation
Nice feature, thanks. |
The new thumb image works well, but there's one thing I can't work out - why is there no fanart for the unwatched episodes? It was the same with #6919 - you'd only see fanart for the watched episodes, and the skin background (ie. bubbles, with Confluence) for the unwatched episodes. This isn't how it works without this patch - when hiding the plot, although you see the episode thumb you also see the fanart. Is there any way to see the fanart, and hide only the thumb? |
Perhaps the set thumb is overwriting all other artwork and the skin uses the fallback |
From a brief look this is happening because of the early return. |
If you have a suggestion how to address it let me know, Ill be in IRC in a bit, if you have a couple of minutes. |
@mkortstiege that works a treat, ive replaced the code with yours, added you as author and here it is the proof: Thank you for the assist much cleaner as well. @MilhouseVH this works a treat and no more issues with fanart. |
can you adjust the commit message as that part between brackets is non relevant |
Done, want a backport? |
no backport |
I guess this still needs adjusting the setting label etc, as pointed out by @Montellese in the previous PR. |
The help string needs adjusting also, I haven't thought about a label text rewording yet, suggestions? |
Ive updated and added the strings changes in un1versal@5b8c3c4 open to suggestions on wording of the label I think the rest is OK. Label is: Show plot for unwatched items (Hides plot and thumb when disabled) |
@@ -10976,11 +10976,11 @@ msgstr "" | |||
|
|||
#: system/settings/settings.xml | |||
msgctxt "#20369" | |||
msgid "Show plot for unwatched items" | |||
msgid "Show plot for unwatched items (Hides plot and thumb when disabled)" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Please stop referencing me unless i need to be involved. I dont care about credits, and i do find all the noise annoying. |
1ea0e88
to
88b59d9
Compare
@mkortstiege testing this further as requested. Setting watched/unwatched the thumbnail for episodes does indeed change to reflect the state. Pending minor strings tweaks, Ide say this is good complete feature though some may not care (I dont use it since plot for movies is also hidden and tbh dont think that is a spoiler really. Side case: Web interface like Chorus2 shows no thumb at all (not the DefaultHidden thumb), when you mark watched you will get a thumbnail as expected, when marking unwatched after a couple refreshes it goes back to no thumb at all. |
Tested latest updates and it's working really well now - not necessarily something I'll use myself, but still a nice feature. |
Nice work, uNiversal! Thank you for cleaning this up. |
yw, Code is courtesy of mkortstiege, but seeing your comment on the other one reminded me this was someone elses feature request on forums. Not something I would use myself but seems a shame to let it goto waste. |
@@ -10976,7 +10976,7 @@ msgstr "" | |||
|
|||
#: system/settings/settings.xml | |||
msgctxt "#20369" | |||
msgid "Show plot for unwatched items" | |||
msgid "Show plot and episode thumbnail for unwatched items" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@MartijnKaijser and others please review the label name, this is the absolute best and only thing I could come up with that is short and covers the topic as a label name. @mkortstiege @Milhouse With this option active I ran Not all episodes have it but certainly more than enough to make me wonder @MilhouseVH you could perhaps test? (I suspect they were added to library with this option to hide spoilers enabled) |
Show / Hide plot for movies and plot and thumbnail for episodes.
Yes, I can confirm that when querying the media library with Apart from caching, this leads on to what should happen in a smartphone app - should the real art be shown when this option is active, or should the app show At the moment the If there's a way to discriminate between a GUI attempt to display the artwork, and a JSON request, then maybe As for the label wording, that seems fine to me. |
I think the if the option is active then any remote apps should show the hidden thumb no they should honour the kodi settings). Now... I can confirm that the only affected episodes that get to cache the DefaultEpisodeHidden.png when they get added to library with this option enabled, in any case caching DefaultEpisodeHidden.png is 100% the wrong thing todo since only way to get the real thuumb back is to remove/rescan or refresh the affected episodes one by one. No idea how to prevent DefaultEpisodeHidden.png from being cached and to ensure the real thmb is cached when this option is active. |
The problem with texturecache.py (and other remote apps) is that the hidden image url isn't valid and can't be downloaded for display in the remote app. When The cache should only ever have one entry for So the solution is one of:
or
Personally, I prefer #1. |
@MilhouseVH I agree that method one is preferable, would it make sense to actually send the setting in the response so the app knows right there what the user prefers? |
I'm also for first suggestion |
I still maintain this should be a multiple selection option to cover all user preferences. eg Avoid spoilers - No / Plot only / Episode Thumbs only / Both As it is now I'll have to leave my 'Hide unwatched episode thumbs' option in fTV because I want to be able to read movie plots while hiding episode thumbs as they're the worse for spoilers. |
I'm fine with Hitcher's idea as well, but maybe it would be more logical to just separate movies from this logic completely. I don't think I've ever been spoiled by a movie summary (that I can remember). Maybe we could have it like this: Hide unwatched: TV episodes, everything, off It's not like we hide TV show summaries, only TV episode summaries. That being said, I won't oppose the PR as-is. I'd rather we have a starting point and then work from there :) |
If it were separated would it not be a good idea to place it with the other episode specific option 'Select first unwatched TV show season / episode'? |
I found another issue with this feature. @MilhouseVH (too many issues now)
@MilhouseVH @mkortstiege I cant really fix those issues or add options like @HitcherUK suggests. |
Are you sure this isn't simply a case of the Home Screen Widget not refreshing - it usually only updates after a database update, or if you enter a node, ie. Recently Added, then return to the Home screen it should update. I had tested the scenario you describe and hadn't seen this problem - for items scanned without this option enabled, when enabling and disabling the "Spoiler" option the widget would display the correct thumb (eventually).
Ah, I wonder if, while scanning new items when the "Spoiler" option is enabled, the "hidden" artwork url is being written into the media library, meaning It seems the point at which the "hidden" image is chosen (and assigned) is simply wrong - it happens too early and therefore has too much unwanted impact. Could it be set/selected later, just before the image is thrown on to the screen by the GUI? Whenever anything queries Kodi for the url, it should always return the real url, but in the case of the GUI the hidden image should be substituted just before the thumb artwork is actually displayed. Perhaps |
I tested that before and didnt see this issue, now I started to see it, I did navigate around to recently added and TV shows and nothing refreshed, only restarting kodi seems to be doing it now, so perhaps turning off this option should trigger an refresh of the widgets and same for when you finish watching an episode? @MilhouseVH perhaps be best to continue discussions on this at http://forum.kodi.tv/showthread.php?tid=130587 or IRC |
And am now slipping into a paint proof suit.
Thank you to mkortstiege for the code assist and change from the original in #6919
Edit: Removed the text so as not to annoy the spiff