Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't mess with the long and short date formats defined in langinfo.xml #7522

Merged

Conversation

Montellese
Copy link
Member

http://trac.kodi.tv/ticket/15993 brought to my attention that we allow each language to define a long and a short date format but then we go and mess it up in the code by allowing to force short day and month names instead of long even when using the long date format. IMO that doesn't make any sense at all and especially not for System.Date info label.

This removes the possibility to force short names and only allows to choose between the long and short date format.

@Montellese Montellese added Type: Fix non-breaking change which fixes an issue RFC PR submitted for gathering feedback labels Jul 15, 2015
@MartijnKaijser
Copy link
Member

landinfo.xml should define long/short date and not something else. Either we should use the long or the short as defined by the chosen language.

Edit: to clarify, yes this PR is as it should be.

@MartijnKaijser
Copy link
Member

jenkins build this please
@Montellese something for backport or not? Could also be for point release if it needs to be tested first

@Montellese
Copy link
Member Author

If we want to backport it we can still do it in a point release. It's not that big of a deal and I'm sure some people won't like it because it changes the way it used to be.

@Montellese Montellese added this to the J**** 16.0-alpha1 milestone Jul 18, 2015
@MartijnKaijser
Copy link
Member

@ronie you see any issues from skinning perspective?

@ronie
Copy link
Member

ronie commented Jul 18, 2015

potentially the space reserved by skins to display the date may be too short to contain the full day & month names.
i see no problem merging this for J*, but i don't think it should be backported to isengard.

MartijnKaijser added a commit that referenced this pull request Jul 18, 2015
don't mess with the long and short date formats defined in langinfo.xml
@MartijnKaijser MartijnKaijser merged commit a2523a6 into xbmc:master Jul 18, 2015
@Montellese Montellese deleted the fix_long_date_with_short_names branch August 9, 2015 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC PR submitted for gathering feedback Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants