[guilib] fix cursor not always shown in keyboard dialog (fixes #16134) #7532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhaggi
added
Type: Fix
This was referenced Jul 17, 2015
|
jenkins build this please |
|
Failure is unrelated |
xhaggi
added a commit
that referenced
this pull request
Jul 17, 2015
…eyboard-dialog [guilib] fix cursor not always shown in keyboard dialog (fixes #16134)
|
From: http://forum.kodi.tv/showthread.php?tid=231092&pid=2055348#pid2055348 "Keyboards cursor is working just one thing if you delete everything you type the first letter remains visible once you start typing it goes away." |
|
Testing my latest #0717 test build which includes this fix and also #7502, I can confirm the above "last-character" behaviour, but also I don't see the cursor until something is typed, and only then does the cursor appear (without this fix, it doesn't appear at all). Before the inclusion of #7502, the cursor is visible as soon as the keyboard dialog is opened (and of course the last character disappears when deleted). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing 708b2ed which fixes the dirty region issue, the changes introduced by c03ecbe (new approach to always show the cursor for keyboard dialog) doesn't work anymore because
SetStyledTextis only called if the control has the focus and therefore the cursor code too.This is an attempt to fix it.
Related trac ticket