[video] use action listener pattern for CPlayerController #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's german in your commit message. |
xhaggi
force-pushed
the
player-controller-as-action-listener
branch
2 times, most recently
from
0f8f8a0
to
ae0960c
Compare
|
@Montellese thanks, rebased. |
xhaggi
changed the title
xhaggi
added
the
Type: Improvement
| CPlayerController(); | ||
| CPlayerController(const CPlayerController&); | ||
| CPlayerController& operator=(CPlayerController const&); | ||
| virtual ~CPlayerController(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Add the virtual that @Memphiz mentioned and it's good to go imo |
xhaggi
force-pushed
the
player-controller-as-action-listener
branch
from
ae0960c
to
6f0d5cd
Compare
|
@Memphiz done jenkins build this please |
|
build erros are unrelated |
xhaggi
added a commit
that referenced
this pull request
Jul 22, 2015
…ener [video] use action listener pattern for CPlayerController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title said this refactors
CPlayerControllerto use the action listener interface/pattern and register/unregister itCApplication. It also changeCPlayerControllerto be Singleton so we can drop the member fromCApplication.@Paxxi mind taking a look