[confluence] fix music OSD alignment and improve visible conditions on OSD

[un1versal]

@da-anda @phil65 @ronie

MusicOSD
1) Had the alignment fix (tested) for player controls it was just too far left imo.
2) Also added visible condition that should allow the record button to become active/visible when the player can record stream this change is untested as I dont use PVR or any circumstances where PlayerControl(record) becomes selectable at all. Please advise on this visible condition change does it also need Player.Recording?

---

Note 1: There are MusicOSD buttons for accessing playlists that is never shown its part of skin textures but no used in skin, any idea why this is @ronie @phil65?

Note 2: Ive adjusted and added visible condition for the gap so that the osd controls aligns on the left hand side irrespective if item is visible or invisible @phil65 please check

---

Before

After - With conditional gap

VideoOSD
1) had visible condition applied to the DVD button, which is only usable when you are playing a DVD/DIsk which has menus VideoPlayer.HasMenu this was tested and seems to work as desired.

Before - playing a normal video

After - playing a normal video

After Playing normal video (subtitle submenu adjustment)

After - playing a DVD

After - playing a DVD (subtitle submenu normal position)

[da-anda]

untested, but looks good from the screenshots. Thanks

[un1versal]

Note 1: There are MusicOSD buttons for accessing playlists that is never shown its part of skin textures but no used in skin, any idea why this is @ronie @phil65?

PING @ronie also I see the playlists OSD buttons were removed in be35997 So I presume we cant use them at all with some visible conditon?

[un1versal]

PING @ronie

[un1versal]

@da-anda, also just fixed (caused by this PR) the subtitles submenu when !VideoPlayer.HasMenucondition without it the subtitles sub menu was not aligned with OSD button while not playing a DVD. So all fixed now.

Now its aligned when normal video and when is also optical media updated screenshots above in OP.

[un1versal]

One more PING since ronie seems not to be reading this.

[phil65]

We have lot to do and this seems far from being urgent. Please dont ping all few days.

[un1versal]

Can anyone review this and let me know if its OK, its not urgent but it does fix the alignment shown and it seems to work as intended.

[un1versal]

Done thx, :) ,much cleaner also. Tested this also and all seems well.

[un1versal]

@da-anda @ronie something weird happens if adsp is enabled this PR doesnt account for it as is
(I simply forgot since adsp isnt usable)

Im lost on what to do when that happens + when canrecord and adsp would be visible.

for instance to make this work I added and this what makes me very confused.

            <control type="image" id="3000">
                <width>-55</width>
                <height>55</height>
                <texture>-</texture>
                <visible>!Player.CanRecord + system.getbool(audiooutput.dspaddonsenabled)</visible>
            </control>

width of minus 55?? but it works, also need to account for when adsp + player.canrecord are both visible, please help

[un1versal]

@da-anda @ronie for comment above I added un1versal@f345eb8 to try account for DSP, but please let me know if its right or incomplete and what to add/change

local tests seem OK. but I can definetly need expert eyes and guidance and a decision what happens to this PR as its 2 months old now.

[un1versal]

Thers already talks of jarvis beta #8239 is this PR being considered at all? @MartijnKaijser