[music] fix missing lyrics from tag when playing from musicdb url

[mkortstiege]

This fixes an issue where the lyrics from tags are not properly shown when playback was started from a musicdb:// url.

This is caused by using the wrong item path when calling the infotag loader. While at it, I've removed the dupe property handling and injected the lyrics to the current item info tag instead.

http://trac.kodi.tv/ticket/16216

@Montellese, @Paxxi

[mkortstiege]

jenkins build this please.

[Paxxi]

This bypasses the database loading entirely so anything downloaded won't show. Can't we load from db as usual and do the extra loading in infomanager::setitem ? That way we won't hit every file on disk and only the ones actually played.

[mkortstiege]

This bypasses the database loading entirely so anything downloaded won't show. Can't we load from db as usual and do the extra loading in infomanager::setitem ? That way we won't hit every file on disk and only the ones actually played.

This only happens when the infomanager requests additional info for he currently playing item. The block is only there to fetch the lyrics from the actual tag (not database). The already known tag information are not overwritten. Unless i read the code utterly wrong i think it's a valid fix.

[mkortstiege]

Fix is confirmed working. @Montellese comments?

[mkortstiege]

Updated. @Montellese, instead of modifying the actual item pointer i've changed it to create a new item based on the translated path. Also adjusted the comment.

[Montellese]

I'll just repeat my previous comment:
Maybe blindly using CFileItem::GetPath() in CMusicInfoTagLoaderFactory::CreateLoader is not the best approach and we should first check if the CMusicInfoTag of the CFileItem has a valid path using CMusicInfoTag::GetURL() and only fall back to CFileItem::GetPath() if it's empty?

[mkortstiege]

It's not blindly using it. CMusicInfoTagLoaderFactory is not about the real tag loading only. As for musicdb:// items it's using the CMusicInfoTagLoaderDatabase. In this specific case we need to grab the lyrics from the actual tag since we're not storing them in the library.

[Montellese]

Ah right I didn't know about CMusicInfoTagLoaderDatabase and thought it was simply about getting the proper tag loader based on the file extension.

[mkortstiege]

Updated.

[Montellese]

Looks good.