-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor builtins #8018
refactor builtins #8018
Conversation
jenkins build this please |
@FernetMenta pick Paxxi/xbmc@ef74a3d for VS projects and a few nitpicks. 👍 and great work @notspiff even if I had some stupid comments when you first PR:ed it :) |
jenkins build this please |
will be used to split off command handling into multiple files
c0b4097
to
28ca16a
Compare
jenkins build this please |
@Paxxi I fixed the remaining build errors and squashed them into related commits. good to go? |
@FernetMenta go ahead and merge |
Executing |
@anaconda are you saying this fails only on OSX? I have no clue what Milhouse build 913 is |
@FernetMenta OpenELEC master builds for the Pi. So OS X and Pi. |
@FernetMenta I can look into this, you go do important work instead :) |
you mean I should prepare my client workshop for tomorrow? :) |
nah, rewrite dvdplayer :) |
Looks like LIRC.Start, LIRC.Stop and LIRC.Send got forgotten, those are now unknown actions. |
@FernetMenta @notspiff I know this is a merged PR, any comment on this regression tho ? |
Sorry fell my list. Will investigate asap, likely tmrw.
|
i'm circumventing by using a python script that I run from kodi-send. |
credits to @notspiff for this excellent work