Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor builtins #8018

Merged
merged 23 commits into from
Sep 12, 2015
Merged

refactor builtins #8018

merged 23 commits into from
Sep 12, 2015

Conversation

FernetMenta
Copy link
Contributor

credits to @notspiff for this excellent work

  • makes CBuiltins a singleton
  • refactors the methods into several files

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@Paxxi
Copy link
Member

Paxxi commented Sep 11, 2015

@FernetMenta pick Paxxi/xbmc@ef74a3d for VS projects and a few nitpicks.

👍 and great work @notspiff even if I had some stupid comments when you first PR:ed it :)

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@FernetMenta
Copy link
Contributor Author

@Paxxi I fixed the remaining build errors and squashed them into related commits. good to go?

@Paxxi
Copy link
Member

Paxxi commented Sep 12, 2015

@FernetMenta go ahead and merge

FernetMenta added a commit that referenced this pull request Sep 12, 2015
@FernetMenta FernetMenta merged commit a00a747 into xbmc:master Sep 12, 2015
@FernetMenta FernetMenta deleted the builtins branch September 12, 2015 10:27
@anaconda
Copy link
Contributor

Executing ./kodi-send.py -a RunScript(/Users/anaconda/x.py)' I'm now getting:
2015-09-14 19:57:17.998 kodi.bin[28112:2498559] Debug Print: Keymapping error: no such action 'runscript' defined
but it's there:
aad7483#diff-4311d3b58263abcf3ced3c4dcc66e224R303
master on OS X and Milhouse build #913.

@FernetMenta
Copy link
Contributor Author

@anaconda are you saying this fails only on OSX? I have no clue what Milhouse build 913 is

@anaconda
Copy link
Contributor

@FernetMenta OpenELEC master builds for the Pi. So OS X and Pi.

@Paxxi
Copy link
Member

Paxxi commented Sep 15, 2015

@FernetMenta I can look into this, you go do important work instead :)

@FernetMenta
Copy link
Contributor Author

you mean I should prepare my client workshop for tomorrow? :)

@Paxxi
Copy link
Member

Paxxi commented Sep 15, 2015

nah, rewrite dvdplayer :)

@lolorc
Copy link

lolorc commented Apr 16, 2016

Looks like LIRC.Start, LIRC.Stop and LIRC.Send got forgotten, those are now unknown actions.
"kodi-send --action=LIRC.Stop" to reproduce => "ERROR: Keymapping error: no such action 'lirc.stop' defined"

@lolorc
Copy link

lolorc commented May 1, 2016

@FernetMenta @notspiff I know this is a merged PR, any comment on this regression tho ?

@notspiff
Copy link
Contributor

notspiff commented May 1, 2016

Sorry fell my list. Will investigate asap, likely tmrw.

  1. mai 2016 11:59 skrev "Laurent" notifications@github.com:

@FernetMenta https://github.com/FernetMenta @notspiff
https://github.com/notspiff I know this is a merged PR, any comment on
this regression tho ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8018 (comment)

@lolorc
Copy link

lolorc commented May 2, 2016

i'm circumventing by using a python script that I run from kodi-send.
funnily enough the Lirc builtin actions work from python; xbmc.executebuiltin("LIRC.Stop", True) for instance.

@notspiff
Copy link
Contributor

notspiff commented May 4, 2016

#9751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants