Add support for the new ffmpeg api #805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2012 11:59
The libav use micro version as 0 The ffmpeg use the micro version as 100+ Simply check if the variable is defined then it is not libav.
|
You can't create two pull requests from the same branch which is why your second commit (libav related meant for #806) appears in this pull request as well. In the future you should create a new branch for every pull request you want to submit and then do your work in those feature-specific branches and send the pull requests from those branches. |
|
Thanks for explanation, this is first time I created some multiple pull requests at once. Should I redo it so it contain only the first commit or you can pick only the first one somehow? |
|
Closing this pull requested as I replaced it by 809 where I created the branch which contain only the relevant patch. |
tru
pushed a commit
to plexinc/plex-home-theater-public
that referenced
this pull request
Nov 12, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
if one builds xbmc with too-new external ffmpeg it fails due to missing new include.
This can be solved by checking for the include in the configure and then just including it when found.
See the attached commit for the fix.
It would be nice to have this also merged to eden branch.
Cheers
Tom