Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for libav api as it sligthly differ. #806

Closed
wants to merge 1 commit into from
Closed

Add support for libav api as it sligthly differ. #806

wants to merge 1 commit into from

Conversation

scarabeusiv
Copy link

The libav use micro version as 0
The ffmpeg use the micro version as 100+

Simply check if the variable is defined then it is not libav.

The libav use micro version as 0
The ffmpeg use the micro version as 100+

Simply check if the variable is defined then it is not libav.
@amejia1
Copy link
Contributor

amejia1 commented Mar 23, 2012

This is something that's already being worked on. See #629.

Thanks anyway.

@scarabeusiv
Copy link
Author

Well I saw it, but it is completely broken so I wrote it from scratch. I was not aware if there is any way how to attach other commits to other owner merge request.

@elupus
Copy link
Contributor

elupus commented Mar 23, 2012

Hold off on stuff like this until we have https://github.com/elupus/xbmc/tree/ffmpeg_0.10.2 merged.

@scarabeusiv
Copy link
Author

Well this is relevant even after the 0.10.2 api merge because libav and ffmpeg will probably differ there forever.

Also as distro packager I would love to see this in eden where the 0.10.2 branch won't prolly end :)

@amejia1
Copy link
Contributor

amejia1 commented Mar 25, 2012

@scarabeusiv Which distro do you work with?

Also, this doesn't address the issue with properly checking for vdpau support in libav. The symbols from libav used to check for vdpau support are no longer exported with libav-0.8.

As elupus said, hold off on this until his pull request is merged. If you want to help, provide your feedback in PR #629.

@scarabeusiv
Copy link
Author

@amejia1 Gentoo like Alexis, but i work on libav and he on ffmpeg :)

Hmm you are right I didn't address the vdpau check part as we export the ac_blabla=yes to be always sattisfied as it is handled by our USE depencencies with no need for the configure script to actually look for it.

So lets wait on th emerge of the 0.8 api (0.10.2 how you would call it) and I will see which patches I will be needing there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants