CGUIDialogSelect: fix focusing the first selected item when opening the dialog #8197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added two more commits to fix the problem that the item list remembers the last scroll/offset position of the list (even if it was a completely different list). |
…or on GUI_MSG_LABEL_RESET
…ndow::OnDeinitWindow() to be able to properly reset the scroll and offset positions
Montellese
force-pushed
the
fix_dialogselect_focusing
branch
from
5fc7e9b
to
0a02f21
Compare
|
Rebased. jenkins build this please |
|
jenkins build and merge. |
|
This PR has introduced a problem: http://trac.kodi.tv/ticket/16406 |
|
some more reports: |
|
I can't reproduce on demand, but this seems to have fixed it for me: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix
CGUIDialogSelectnot focusing the first selected item when opening the dialog with at least one "pre-selected" item. The current logic cleans the list of selected items and then tries to set the focus on the first selected item but since the list has just been cleared that's obviously not going to work.This does NOT fix the problem that the item list remembers the last scroll/offset position of the list (even if it was a completely different list).