RFC: Play10bit #845

elupus · 2012-04-04T21:48:47Z

So, this branch adds support for avoiding the 10bit to 8bit color space conversion and letting the GPU get the full precision data.

I mainly want some comments on the WIP commit. I really don't like including that dvdplayer header in there. At the same time i'd rather not pull in renderer headers into dvdplayer.

Pulling in ffmpeg's pixfmt might be one option. But i'm not sure how we would handle any pixelformats not defined by that. Comments are welcome.

jmarshallnz · 2012-04-06T03:18:44Z

A separate header (or using rendermanager or something similar) seems the best way to go, yeah.

elupus · 2012-04-11T22:55:36Z

Christ that made the diff of this thing grow... I suppose the first 2 commits are really quite separate since they are mainly refactoring.

elupus · 2012-04-16T19:46:20Z

@CrystalP could you give this a whirl on windows with dxva? Just want to make sure i didn't break anything there.
@davilla A test on OSX would be nice

davilla · 2012-04-16T21:03:23Z

borked in osx, no video and where the video would be is pure red.

davilla · 2012-04-17T10:02:55Z

Any clues why I see red, I poke around and after climbing out of the m_format showing RENDER_FMT_NONE hole, I could not see anything obvious.

elupus · 2012-04-17T13:47:17Z

No not really. Will give linux a go later. Tested on win last time I worked
on it. Can have missed something.

xbmc/cores/VideoRenderers/VideoShaders/WinVideoFilter.cpp

+    || !m_YUVPlanes[1].Create(texWidth / 2, m_sourceHeight / 2, 1, 0, D3DFMT_L16, D3DPOOL_DEFAULT)
+    || !m_YUVPlanes[2].Create(texWidth / 2, m_sourceHeight / 2, 1, 0, D3DFMT_L16, D3DPOOL_DEFAULT))
+    {
+      CLog::Log(LOGERROR, __FUNCTION__": Failed to create YV12 planes.");


CrystalP · 2012-04-17T20:09:42Z

I'll give dxva decoding and/or rendering a go tonight. Did you benchmark CPU/GPU usage?

elupus · 2012-04-18T19:58:36Z

Sådär, hade blivit en drös buggar i senaste rebasen.. @davilla nu får du gärna försöka igen.

@CrystalP har inte gjort några speciella benchmarks, men det borde hjälpa en del. Det skippar en memcpy med shift på varje byte.

elupus · 2012-04-18T20:15:54Z

lol.. i wonder why i wrote that in swedsh.. A translation might be in order:

There we go, had managed to introduce a bunch of bugs in the last rebase.. @davilla feel free to give it a try again.

@CrystalP havn't done any real benchmarks, but it should help some. It skips a memcpy with a shift on each byte.

CrystalP · 2012-04-19T05:52:29Z

OK, tried it and software decoding + pixel shaders or software render work
dxva decoding works.
software decoding + dxva renderer on 10 bit material doesn't work because a 10/16 bit copy to GPU memory is not implemented in CProcessor::Add() of dxva.cpp. But would it make sense to add, instead of letting ffmpeg convert to 8bit?

elupus · 2012-04-19T06:36:54Z

Depends on if dxva processor can handle it. Our 10 bit data is stored in
the lower bits of a 16bit value. So one might need to scale it. If that
can't be done on gpu, its rather pointless.

CrystalP · 2012-04-20T01:52:45Z

I'll try it but I'd be surprised if they could.

In the meantime, something is screwing with dxva rendering after dxva decoding - nVidia drivers compensate, but ATI's do not.

At the beginning of CWinRenderer::SelectRenderMethod, m_Processor.Open() is called. Problem is that as its last parameter, it expects a D3D input data format for the processor, ie the format of the data after decoding (for ex. MAKEFOURCC('Y','V','1','2')). With this PR, it receives RENDER_FMT_DXVA, which means nothing to D3D and fails badly with ATI when querying processor capabilities, creating textures, ...

elupus · 2012-04-20T06:22:52Z

Right. I knew there was something with that.

elupus · 2012-04-20T21:21:58Z

@CrystalP could you give it a go again?

elupus · 2012-04-22T17:32:41Z

Okey, so I've rebased and squashed in changes to their rightful place. Should be ready to go I think. Still needs a test on GLES platforms thou.

davilla · 2012-04-23T02:28:33Z

gles and hw codec exclude fixes -> http://dl.dropbox.com/u/14341410/gles-10bit.patch

elupus · 2012-04-23T07:18:58Z

what format was that? doesn't seem to be a text file?

davilla · 2012-04-23T10:14:15Z

opps, my bad, dropped an alias instead of the real file. Try again with same URL.

elupus · 2012-04-23T20:22:33Z

Thanx @davilla, have incorporated the changes. Noticed some ordering errors that would cause bisecting errors. I think they should be bisectable now (have not tested thou)

I think this should be ready to pull now.

xbmc/cores/VideoRenderers/VideoShaders/YUV2RGBShader.cpp

+    matrix *= TransformMatrix::CreateScaler(64.0
+                                          , 64.0
+                                          , 64.0);
+  }


davilla · 2012-04-26T21:01:34Z

elupus, have you tried mpeg2 iso's ? I'm crashing in CopyPicture in iOS.

CrystalP · 2012-04-27T06:43:56Z

OK now for dxva decoding. I checked the dxva processors, they only accept a few 8 bit formats. Maybe future GPUs or drivers will add more but that's it for now, and they can't work properly with data direct from ffmpeg.

Gave a DVD a spin, all renderers are fine with libmpeg2 decoding on Windows.

davilla · 2012-04-27T17:13:19Z

ok, mpeg2 iso's under iOS are fine with a recent pull. must have been some local issue.

OSX/iOS signoff for inject.

davilla · 2012-04-30T18:14:35Z

ping elupus, found two more, see http://pastebin.com/qUR6phWY

…ector itself This reduces the prototyping needed and allows additional parameters to be added.

…nderers

This should really be moved to some more generic location.

elupus · 2012-05-01T10:24:59Z

I intend to merge this in a day or two. I'll look at that copy & paste regarding profiles later and factor it out into DVDCodecUtils most likely.

elupus · 2012-05-01T10:25:37Z

That profile change is technically separate from this pull request and could have been applied before this goes in. But it can go in with this pull too.

[dvdplayer/videorenderers] Handle 10bit and 16bit color space conversion on GPU

* PR-845_PP_filter_extensions: closes xbmcgh-845 Add extension filter to associated files for Post Processing

Updated **Womble** provider to use 'tv-sd' and 'tv-hd' categories instead of the now defunct 'TV-x264'. Add extension filter to associated files for Post Processing xbmc#845 * One case example is if you only want subs, you could create the filter '.idx, .sub, .srt'. We strip spaces and ignore case when matching against the filter. * This is useful for those that do not have the ability to setup a cleanup script in their downloader. Re-arrange snatched+download SQL to be easier to read and compare (split snatched and download out). * Show **downloaded+snatched** on homepage rather than the combine number, show tooltip that explains it xbmc#842 * Fix sorting shows with more than 100k episodes Cleaned up season pack vs single episode searching logic * Added check to only consider a full season pack if the last episode in the season airdate is older than 7 days or if the last aired ep is older than 'today'. * Fix **BTN** backlog search for single episode searches, remove duplicate search parameters. Fix **OMGWTFNZBS** proper/repack search Post-Processing fixes * Fix release name not set on air-by-date shows during post-processing * Fix processing season 0 Change clean proper name to check against history Should prevent a proper from being re-downloaded (such as the reposted '-RP' releases) Change setting status to **UNAIRED** for future episodes (GC-2397) Revised Roman Numerals conversion routine to be stricter (ex: IIII is not 4, IL is not 1) and raise error instead of defaulting to 0. Regex tweaks. Pull xbmc#841 * Add '480p' to our regex to reduce the chance of it being matched as the season/ep or multi-ep reference. * Filter out releases like 'Louie.S02E11.PROOFFiX.720p.BluRay.x264-DEiMOS' and 'Rome.S02.DiRFiXES.720p.BluRay.x264-SiNNERS' as they are useless for our purposes. Season 0 fix. Pull xbmc#843 * Exclude specials from being changed to wanted automatically because of the daily search. * When excluding specials use '> 0' rather than '!= 0' just to be more efficient.

CrystalP reviewed Apr 17, 2012
View reviewed changes

CrystalP reviewed Apr 24, 2012
View reviewed changes

xbmc/cores/VideoRenderers/VideoShaders/YUV2RGBShader.cpp

matrix *= TransformMatrix::CreateScaler(64.0

, 64.0

, 64.0);

}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

elupus added 3 commits May 1, 2012 12:20

changed: move dvdplayer pixel formats to separate header

0229c38

changed: use render formats enum in renderers

15d6e05

changed: make CDVDCodecOption a class holding a vector instead of a v…

c8e7cbd

…ector itself This reduces the prototyping needed and allows additional parameters to be added.

elupus added 7 commits May 1, 2012 12:20

changed: move selection of supported pixel formats for decode into re…

dac0780

…nderers

added: support 10/16bit format in dvdplayer

b5b042c

added: support for 10/16bit pixelformats in d3d renderer

250dfdb

added: support 10/16 bit formats in opengl renderer

2a80521

[renderer] drop depreciated config flags

ae02fbd

added: missing render format strings

b7d6c53

This should really be moved to some more generic location.

[chd/vda/tbx] don't allow 10bit formats for hw decode

94c07e5

elupus added a commit that referenced this pull request May 2, 2012

Merge pull request #845 from elupus/play10bit

41887d5

[dvdplayer/videorenderers] Handle 10bit and 16bit color space conversion on GPU

elupus merged commit 41887d5 into xbmc:master May 2, 2012

This was referenced Feb 6, 2014

[dxva] Fix black screen when trying to render Hi10P video with DXVA2/DXVA-HD #4160

Closed

Prevent unnecessary colorspace conversions (regression in #4163) #4192

Merged

HolgerW1 pushed a commit to HolgerW1/xbmc that referenced this pull request Sep 26, 2014

Merge branch 'PR-845_PP_filter_extensions' into development

a3bfb87

* PR-845_PP_filter_extensions: closes xbmcgh-845 Add extension filter to associated files for Post Processing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RFC: Play10bit #845

RFC: Play10bit #845

elupus commented Apr 4, 2012

jmarshallnz commented Apr 6, 2012

elupus commented Apr 11, 2012

elupus commented Apr 16, 2012

davilla commented Apr 16, 2012

davilla commented Apr 17, 2012

elupus commented Apr 17, 2012

This comment was marked as spam.

CrystalP commented Apr 17, 2012

elupus commented Apr 18, 2012

elupus commented Apr 18, 2012

CrystalP commented Apr 19, 2012

elupus commented Apr 19, 2012

CrystalP commented Apr 20, 2012

elupus commented Apr 20, 2012

elupus commented Apr 20, 2012

elupus commented Apr 22, 2012

davilla commented Apr 23, 2012

elupus commented Apr 23, 2012

davilla commented Apr 23, 2012

elupus commented Apr 23, 2012

This comment was marked as spam.

This comment was marked as spam.

davilla commented Apr 26, 2012

CrystalP commented Apr 27, 2012

davilla commented Apr 27, 2012

davilla commented Apr 30, 2012

elupus commented May 1, 2012

elupus commented May 1, 2012

RFC: Play10bit #845

RFC: Play10bit #845

Conversation

elupus commented Apr 4, 2012

jmarshallnz commented Apr 6, 2012

elupus commented Apr 11, 2012

elupus commented Apr 16, 2012

davilla commented Apr 16, 2012

davilla commented Apr 17, 2012

elupus commented Apr 17, 2012

This comment was marked as spam.

CrystalP commented Apr 17, 2012

elupus commented Apr 18, 2012

elupus commented Apr 18, 2012

CrystalP commented Apr 19, 2012

elupus commented Apr 19, 2012

CrystalP commented Apr 20, 2012

elupus commented Apr 20, 2012

elupus commented Apr 20, 2012

elupus commented Apr 22, 2012

davilla commented Apr 23, 2012

elupus commented Apr 23, 2012

davilla commented Apr 23, 2012

elupus commented Apr 23, 2012

This comment was marked as spam.

This comment was marked as spam.

davilla commented Apr 26, 2012

CrystalP commented Apr 27, 2012

davilla commented Apr 27, 2012

davilla commented Apr 30, 2012

elupus commented May 1, 2012

elupus commented May 1, 2012