[events] change level enum to enum class #8461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamland
added
the
Type: Cleanup
|
Looks good. |
|
Fine with me. I've written this before we moved to C++11 so it wasn't available yet. |
|
jenkins build this please |
|
@MartijnKaijser no point building, then merging other prs. It'll break build now so don't merge this yet |
tamland
force-pushed
the
event_level_enum
branch
from
a6d5945
to
0451556
Compare
|
jenkins build and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures it can't be accidentally passed to a different parameter again.