Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Win32File] Fix invalid assert expression #8551

Merged
merged 1 commit into from
Dec 18, 2015
Merged

[Win32File] Fix invalid assert expression #8551

merged 1 commit into from
Dec 18, 2015

Conversation

AchimTuran
Copy link
Member

Zero byte file write under windows triggers an invalid assert and stops Kodi.

@AchimTuran AchimTuran added Type: Fix non-breaking change which fixes an issue Platform: Windows labels Dec 10, 2015
@stefansaraev
Copy link
Contributor

cc @Karlson2k

@AchimTuran AchimTuran mentioned this pull request Dec 10, 2015
Merged
@AchimTuran AchimTuran added this to the Jarvis 16.0-beta4 milestone Dec 10, 2015
@stefansaraev stefansaraev modified the milestones: K***** 17.0-alpha1, Jarvis 16.0-beta4 Dec 10, 2015
@AchimTuran AchimTuran modified the milestone: K***** 17.0-alpha1 Dec 10, 2015
@MartijnKaijser
Copy link
Member

jenkins build this please
status?

@AchimTuran
Copy link
Member Author

I waited one week without response.

I merge it now.

AchimTuran added a commit that referenced this pull request Dec 18, 2015
@AchimTuran
Merge pull request #8551 from AchimTuran/win32_0-byte-file-write
da7b756 
[Win32File] Fix invalid assert expression
@AchimTuran AchimTuran merged commit da7b756 into xbmc:master Dec 18, 2015
@Karlson2k
Copy link
Member

FIx is correct of course.
Should be like similar assert in read.

@AchimTuran AchimTuran deleted the win32_0-byte-file-write branch January 17, 2016 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Platform: Windows Type: Fix non-breaking change which fixes an issue
Projects
None yet
Milestone
Krypton 17.0-alpha1
Development

Successfully merging this pull request may close these issues.
4 participants
@AchimTuran @stefansaraev @MartijnKaijser @Karlson2k