Remove mutebug dialog

[ronie]

it's always been a pita for skinners to have two dialogs for displaying volume info in kodi,
the major issue is getting a decent transition between the volumbar/mutebug dialogs.

this merges the mutebug functionality into the volumebar dialog.
one less xml for skinners to code and no more odd workarounds needed to get a seamless transition.

[MartijnKaijser]

\o/

[MartijnKaijser]

@mkortstiege for a code check :)

[mkortstiege]

Looks good to me. Thanks.

[ronie]

jenkins build this please

[ronie]

updated as @xhaggi suggested.

[xhaggi]

one last question how do we handle volume changes e. g. mute/unmute with json-rpc? do we also send the necessary actions?

[ronie]

tested json-rpc with the Input.ExecuteAction method. works ok.

[xhaggi]

@ronie you can also use Application.SetMute and Application.SetVolume json-rpc commands.

See http://kodi.wiki/view/JSON-RPC_API/v6#Application.SetMute

Both send the desired actions except if you directly set a volume value which calls CApplication::SetVolume

See https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/json-rpc/ApplicationOperations.cpp#L65
https://github.com/xbmc/xbmc/blob/master/xbmc/Application.cpp#L4744

Could you please verify if this will work?

[xhaggi]

Ahh sorry I missed that line https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/json-rpc/ApplicationOperations.cpp#L92 which triggers the action in any case.

[MartijnKaijser]

jenkins build this please

[MartijnKaijser]

jenkins build this please