-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mutebug dialog #8875
Remove mutebug dialog #8875
Conversation
\o/ |
e8fa780
to
df9705d
Compare
@mkortstiege for a code check :) |
Looks good to me. Thanks. |
jenkins build this please |
|
||
void CGUIDialog::CancelAutoClose(void) | ||
{ | ||
if (m_autoClosing && m_active) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
df9705d
to
863cc98
Compare
863cc98
to
71eb7a3
Compare
updated as @xhaggi suggested. |
one last question how do we handle volume changes e. g. mute/unmute with json-rpc? do we also send the necessary actions? |
tested json-rpc with the Input.ExecuteAction method. works ok. |
@ronie you can also use See http://kodi.wiki/view/JSON-RPC_API/v6#Application.SetMute Both send the desired actions except if you directly set a volume value which calls See https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/json-rpc/ApplicationOperations.cpp#L65 Could you please verify if this will work? |
Ahh sorry I missed that line https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/json-rpc/ApplicationOperations.cpp#L92 which triggers the action in any case. |
jenkins build this please |
1 similar comment
jenkins build this please |
it's always been a pita for skinners to have two dialogs for displaying volume info in kodi,
the major issue is getting a decent transition between the volumbar/mutebug dialogs.
this merges the mutebug functionality into the volumebar dialog.
one less xml for skinners to code and no more odd workarounds needed to get a seamless transition.