[gui] merge skin XMLs for MusicPlaylist and VideoPlaylist #8910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine by me. At some point we might want to merge the actual dupe code of those sections as well though. |
|
Can you sqash this please? I'll try to have a look on the c++ side of things Edit: NVM, it's not that simple to merge them as they both inherit from video or music specific classes |
|
tested and works ok. |
|
@as razzee says it's not entirely trivial. i did try it at some point, holding a reference to a GUIMediaWindow to apply the operations to. iirc i got bitten by protected things and had to friend and at that point i gave up. friend is not an acceptable solution imo. |
phil65
force-pushed
the
merge_playlist_windows
branch
from
c738784
to
2a4b795
Compare
|
squashed and rebased. |
razzeee
added
Component: GUI engine
Component: Skin
Type: Cleanup
razzeee
added a commit
that referenced
this pull request
Jan 26, 2016
[gui] merge skin XMLs for MusicPlaylist and VideoPlaylist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merges the two playlist windows.
One of those had to deal with mixed content before already anyways, so shouldnt be a big deal for skinners to make this change.
@ronie
@mkortstiege