Don't hide parent folder icon when browsing by watched movie/episode

[razzeee]

When you filter for Watched in the video library. You'll loose the goto parent folder icon, rendering you unable to go up in the hierarchy via the menu.

This fixes the problem.

[Montellese]

Don't we have a similar logic somewhere else which also has to take care of season flattening etc? IIRC I've seen similar code with the same exceptions somewhere else.

[razzeee]

Having slept over it I think we should/could probably do it the same way we're handling the "* all albums" stuff now?

Will have to search for that other code then. Btw it seems that the flattening code also has a problem, as it seems to still add the "season" level to the "history" for browsing back up. Not sure if I named those concepts correctly as I haven't read up on them.

[Montellese]

We could inject the parent item using a list item modifier but it would obviously affect all views / nodes and not just season view. What might be an issue is that the list modifier has no idea about the watched / unwatched state.

[razzeee]

I wouldn't think it will be and I think we want this everywhere. As 99% of our menus have a parent. The important info is basically hasParent yes/no

[razzeee]

So should I try to change this @Montellese or are we good with this PR?

[Montellese]

We can leave it like this for now (will also make backporting easier) but would be nice if we could someday refactor the two very similar implementations into one.

[razzeee]

Not sure how I feel about backporting.

jenkins build this please

[razzeee]

I would like to merge this tomorrow, so speak up if anyone sees a problem

[MilhouseVH]

This PR is causing a segfault when navigating into empty folders with "Show parent folder items" disabled/unchecked.

Without this PR there is no problem.

To reproduce:

1. Add an empty folder to sources.xml, eg:

        <source>
            <name>Local Videos</name>
            <path pathversion="1">/home/neil/videos/</path>
            <allowsharing>true</allowsharing>
        </source>

2. Contents of folder:

$ ls -la /home/neil/videos/
total 8
drwxrwxr-x  2 neil neil 4096 Feb 27 13:49 .
drwxr-xr-x 45 neil neil 4096 Feb 27 13:49 ..

3. Disable Show parent folder items in Settings > Appearance > File lists

4. Navigate into empty folder Videos > Files > Local Videos, and Kodi will segfault.

crashlog

(I intended to create a trac ticket for this, but I can't login to kodi.trac.tv right now - login issues)

[popcornmix]

Funny, I has a crash that sounded like this last night. Let's check if there's a crashlog...
http://sprunge.us/BXLC

Yep - looks like the same one. I think I clicked on video add-ons which was empty.