[rfc][depends] bump giflib but mainly to include static libs for texturepacker #9077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paxxi
added
RFC
|
5.1.1 had both static and dynamic. You could drop the dll though |
|
ahh hadn't noticed that, no debug version though but not sure if it's needed. |
|
nitpick: win32 depends only |
|
obsoleted by #9856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fetzerch asked yesterday about having a static library version of giflib for texturepacker so I rebuilt the package including static versions as well as the dll versions.
I haven't uploaded the package yet as I'm thinking we might get rid of the dll versions. They're currently only used by texturepacker and if that is built statically we can get rid of the dll's and avoid having them be included in the distribution.
Thoughts? @ace20022 @Montellese as you're familiar with giflib and texturepacker.