Userrating in MusicOSD

[razzeee]

This adds our 1-10 userrating dialogselect as a bindable key. So skins can call "showrating" and it will show up. Should also work for keymaps.

It also changes the onscreen rating display as you change it.
The only drawback is, that as long as the song you just rated is playing, you can reopen the rating dialog and won't see the rating preselected. If it was rated previous to your play, this will work.

I also need a skinner to change redo my skin work, as mine was just for tests.
So any takers? @phil65 @HitcherUK ?

[phil65]

wouldnt "setrating" be more appropriate?

[razzeee]

Well it's also showsubtitles

[phil65]

"showsubtitles" does something entirely different. ;) It´s basically a toggle for an overlay, so "show..." makes sense there.
i would take increaserating/decreaserating as a reference, in those cases the first part of the word indicates what we actually do with the rating.

[Montellese]

Since it throws up a dialog to change the rating IMO it should be "setrating" and not "showrating".

[razzeee]

Well I certainly don't care what name we use, if you guys want setrating, let's do it.

Have you checked the code otherwise @Montellese ?

[razzeee]

Changed to "setrating"

Also got the skin work from @HitcherUK
Thanks!

[Tolriq]

@razzeee anyway to have also the rating updated when updating song rating for currently playing song with AudioLibrary.SetSongDetails ?

[razzeee]

I'll have to look into that, have you tried it and it doesn't work?

[Tolriq]

Not with this patch, but it's like that since I implemented song ratings in Yatse. I don't see anything in this PR that could change that.

[razzeee]

Correct, shouldn't be affected by this PR. But feels weird as it updates fine, when I set it from the new popup window. Will need some investigation.

[Tolriq]

Well from your code I suppose the JSON part just miss a call to

CGUIMessage msg(GUI_MSG_NOTIFY_ALL, 0, 0, GUI_MSG_UPDATE_ITEM, 0, track);

but it's pure guess.

[razzeee]

Correct, it's due to that call. But I'm not sure if it's okay to call that from the json methods. @Montellese

[razzeee]

jenkins build this please

[un1versal]

@razzeee
This broke the OSD controls alignment to right hand side, its now off by 3 miles from where it should be

The alignment Of the OSD elements on left hand side should be to the far right EXACTLY under the time stamp.