-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Userrating in MusicOSD #9094
Userrating in MusicOSD #9094
Conversation
wouldnt "setrating" be more appropriate? |
Well it's also showsubtitles |
"showsubtitles" does something entirely different. ;) It´s basically a toggle for an overlay, so "show..." makes sense there. |
Since it throws up a dialog to change the rating IMO it should be "setrating" and not "showrating". |
Well I certainly don't care what name we use, if you guys want setrating, let's do it. Have you checked the code otherwise @Montellese ? |
Pops out our 1-10 rating dialogSelect Can be called via a button press also: "setrating"
66422af
to
ca27828
Compare
@razzeee anyway to have also the rating updated when updating song rating for currently playing song with AudioLibrary.SetSongDetails ? |
I'll have to look into that, have you tried it and it doesn't work? |
Not with this patch, but it's like that since I implemented song ratings in Yatse. I don't see anything in this PR that could change that. |
Correct, shouldn't be affected by this PR. But feels weird as it updates fine, when I set it from the new popup window. Will need some investigation. |
Well from your code I suppose the JSON part just miss a call to
but it's pure guess. |
Correct, it's due to that call. But I'm not sure if it's okay to call that from the json methods. @Montellese |
jenkins build this please |
@razzeee The alignment Of the OSD elements on left hand side should be to the far right EXACTLY under the time stamp. |
@@ -258,10 +258,6 @@ | |||
<visible>!MusicPlayer.Content(LiveTV)</visible> | |||
<onclick>PlayerControl(Random)</onclick> | |||
</control> | |||
<control type="image" id="2300"> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This adds our 1-10 userrating dialogselect as a bindable key. So skins can call "showrating" and it will show up. Should also work for keymaps.
It also changes the onscreen rating display as you change it.
The only drawback is, that as long as the song you just rated is playing, you can reopen the rating dialog and won't see the rating preselected. If it was rated previous to your play, this will work.
I also need a skinner to change redo my skin work, as mine was just for tests.
So any takers? @phil65 @HitcherUK ?