Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] - add support for tvshow status #9537

Merged
merged 1 commit into from Apr 3, 2016

Conversation

@phil65
Copy link
Member

phil65 commented Apr 3, 2016

Follow-up to #9516
Forgot to take care of the json side.
@anaconda

@Montellese

This comment has been minimized.

Copy link
Member

Montellese commented Apr 3, 2016

jenkins build and merge

@Montellese Montellese added this to the Krypton 17.0-alpha1 milestone Apr 3, 2016
@jenkins4kodi jenkins4kodi merged commit 5cf31ed into xbmc:master Apr 3, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
default Merged build started.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Tolriq

This comment has been minimized.

Copy link
Contributor

Tolriq commented Apr 3, 2016

@Montellese should not new params be at the end for compat ?

Seeing this mostly never followed maybe it should be noticed in the doc that only named parameters are supported ?

@Montellese

This comment has been minimized.

Copy link
Member

Montellese commented Apr 3, 2016

You're right. I thought this was the returned property. It needs to be moved to the end of the list. For any direct parameters the order matters. For any returned object properties the order doesn't matter. @phil65 can you fix that in the API definition?

@phil65 phil65 deleted the phil65:listitem_status branch Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.