[gui] fix bug when opening playlists with smartplaylisteditor several times

[phil65]

Example: call

ActivateWindow(smartplaylisteditor,special://skin/playlists/inprogress_movies.xsp)

several times and you will notice that the rule list gets longer and longer because the previous rules were not cleared.
@Montellese for guidance please, not sure what the best place is to do the .Reset()

[Montellese]

Can you check what happens when you open the smartplaylist editor for a specific xsp (With above call) and then open it without one with ActivateWindow(smartplaylisteditor)? From the looks of your change you will still see the rules from the initial xsp which we'd have to handle as well.

[phil65]

ah ok, I thaught this codepath would only be used when the additional playlistpath param was passed via ActivateWindow().
Should I just move the call up some few lines, right before

if (!startupList.empty())

?

[Montellese]

Probably yeah.

[phil65]

@Montellese tried this again but moving that line up introduces other issues (when called from EditPlaylist(), m_playlist is set up before GUI_MSG_WINDOW_INIT already and thus gets overwritten there again)

I now tried to do the Reset() in GUI_MSG_WINDOW_DEINIT and everything worked fine during a quick test. Is this fix okay-ish?

[Montellese]

Actually this is something I've wandered a lot when working with dialogs. A lot of dialogs have to be manually reset in the code before they can be used. I always wondered why they weren't automatically reset when they were closed.

It should be fine as long as m_playlist isn't used by whoever opened the dialog in the first place (which shouldn't be the case because it's not public anyway).

[phil65]

Actually this is something I've wandered a lot when working with dialogs. A lot of dialogs have to be manually reset in the code before they can be used. I always wondered why they weren't automatically reset when they were closed.

Agreed.

It should be fine as long as m_playlist isn't used by whoever opened the dialog in the first place (which shouldn't be the case because it's not public anyway).

Ok. jenkins build this please.