[guilib] - fix for multiimage controls in case imagepath switches to empty #9715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil65
added
Type: Fix
|
confirmed. works as expected. |
|
You might want to invalidate m_image in order to properly proceed with the new image width. Might not be needed though. Other than that, it looks good to me. |
|
As discussed via Slack, that shouldnt be needed. Thx for reviewing, jenkins build this please. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the content of multiimage controls does not clear when switching to an empty path, so you still get the image(s) of the previous path.
I think @BigNoid also stumbled over this one already.
@ronie for confirmation and perhaps @mkortstiege for code in case you have some minutes :)