Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] - remove some unused stuff from ControlFactory #9822

Merged
merged 2 commits into from
May 17, 2016

Conversation

phil65
Copy link
Contributor

@phil65 phil65 commented May 16, 2016

remove some unused stuff from ControlFactory.
@ronie "imagefolder" and "imagefolderfocus" is some outdated garbage, right?

@ronie
Copy link
Member

ronie commented May 16, 2016

@ronie "imagefolder" and "imagefolderfocus" is some outdated garbage, right?

never heard of 'm. it's not used anywhere, so safe to remove.

spinInfo is used by the settings spincontrol though.

@phil65
Copy link
Contributor Author

phil65 commented May 16, 2016

settings spincontrol uses labelInfo instead of spinInfo
https://github.com/xbmc/xbmc/blob/master/xbmc/guilib/GUIControlFactory.cpp#L1474

@ronie
Copy link
Member

ronie commented May 16, 2016

ah, ok. good to go then.

@phil65
Copy link
Contributor Author

phil65 commented May 16, 2016

jenkins build this please.

@phil65 phil65 merged commit b47b521 into xbmc:master May 17, 2016
@hudokkow hudokkow added the Type: Cleanup non-breaking change which removes non-working or unmaintained functionality label May 24, 2016
@hudokkow hudokkow added this to the Krypton 17.0-alpha2 milestone May 24, 2016
@phil65 phil65 deleted the controlfactory_cleanup branch December 18, 2016 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants