Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioDSP fixes #9870

Merged
merged 3 commits into from
May 25, 2016
Merged

AudioDSP fixes #9870

merged 3 commits into from
May 25, 2016

Conversation

AchimTuran
Copy link
Member

@FernetMenta
This PR includes the changes from #9855.

  • enabled AudioDSP keeps ActiveAE buffering and buffering, because of a wrong timestamp
  • add missing channel handling inside AudioDSP
  • deny ActiveAE stream creation with enums out of range (inspired by [AE] Fix create AE stream with invalid data format #8460)
    And the fixes for VS2015.
    double clicking the VS solution file opens VS2013, which is wrong
    add missing dependencies in VS to compile add-on callback libraries before Kodi executable

@AchimTuran AchimTuran added Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality Component: ADSP Platform: Windows labels May 23, 2016
@AchimTuran AchimTuran added this to the Krypton 17.0-alpha2 milestone May 23, 2016
@AchimTuran
Copy link
Member Author

jenkins build this please

@AchimTuran
Copy link
Member Author

@FernetMenta, @fritsch or @AlwinEsch
This PR is from my side finished. Hopefully jenkins is also happy with my changes.

@FernetMenta
Copy link
Contributor

+1
@AlwinEsch your button

@FernetMenta
Copy link
Contributor

not sure if bbe8cba should be part of this pr
btw: Windows build failed

@AlwinEsch
Copy link
Member

AlwinEsch commented May 25, 2016

About the windows build, has checked the UUID and was from my "kodiAddonDevKit-SharedLib-API3.vcxproj" but nowhere in Project files defined anymore, a little bit crazy. Maybe somewhere in Jenkins a bad temporary file?

EDIT: Want to see jenkins for windows correct.

@AchimTuran
Copy link
Member Author

@FernetMenta

not sure if bbe8cba should be part of this pr
I could extract this commit and create a new PR if you want.

@FernetMenta
Copy link
Contributor

@AchimTuran I am not a Windows dev. This caught my attention because the Windows build failed.

@AchimTuran
Copy link
Member Author

jenkins build this please

@AchimTuran
Copy link
Member Author

Currently I don't know why the Windows build failed. But I like to merge the changes for AE. So far the VS2015 changes are optional.

@AchimTuran AchimTuran merged commit ce686f5 into xbmc:master May 25, 2016
@AchimTuran AchimTuran changed the title Audio dsp vs2015 fixes AudioDSP fixes May 25, 2016
@AchimTuran AchimTuran deleted the AudioDSP_VS2015_fixes branch June 13, 2016 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ADSP Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants