Fixed album artist scanning when using Vorbis comments #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st instead of m_artist.
|
That looks very much like a c&p typo I introduced in 6e367ad. As I almost never use the music library I obviously didn't notice. Thanks for spotting and fixing it. |
ghost
assigned
Montellese
added a commit
that referenced
this pull request
May 22, 2012
Fixed album artist scanning when using Vorbis comments
dalehamel
pushed a commit
to RasPlex/plex-home-theatre
that referenced
this pull request
Feb 13, 2014
tru
pushed a commit
to RasPlex/plex-home-theatre
that referenced
this pull request
Feb 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the album artists in CMusicInfoTag::AppendAlbumArtist (atm only used by flacs/oggs with Vorbis comments).
Currently when adding such files to the db (with ALBUMARTIST or ALBUM ARTIST set), the file's album artist will be added as additional artist. The GUI shows this as ARTIST / ARTIST - TITLE and the album will appear under 'Various Artists'.
The fix is rather small, it looks like a typo in the code.