[WIP] AudioDSP fixes #9949
[WIP] AudioDSP fixes #9949
Conversation
AchimTuran
added
Type: Fix
| @@ -436,9 +436,10 @@ bool CActiveAEBufferPoolResample::ResampleBuffers(int64_t timestamp) | |||
| if (!m_dspSample) | |||
| m_dspSample = m_dspBuffer->GetFreeBuffer(); | |||
|
|
|||
| m_dspSample->timestamp = in->timestamp; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
jenkins build this please |
|
How to build kodi android on Travis |
|
While this fixes the crash on Pi, it doesn't make it work. mediainfo of test file: http://paste.ubuntu.com/17288193/ |
|
Also after playing the file then disabling ADSP I get a crash with |
I didn't say that the enitre problem is sovled with these fixes. Currently there is a problem with synchronization and it produces scratchy audio output. But the crashes on my Pi2 are gone.
Could you create a backlog please? |
|
Sorry I forgot to add the WIP label and title 😅 |
|
Pretty sure the high pitched / scratchy audio is due to interpreting buffers with incorrect number of channels or format or planar. |
|
This time I just clicked enable then disable on ADSP in system audio settings. This was crash: |
|
@popcornmix The crash is not related to the AudioDSP system and is created inside an add-on. If you disable adsp.biquad.filters the crash should go away. Otherwise if you have the time please create another backlog. |
|
Okay, with biquad disabled in settings I no longer get the crash when disabling nor the distorted audio. |
I know that this is confusing for the users and I try to fix this in my new branch. Edit: |
|
@FernetMenta, @AlwinEsch, @popcornmix, @fritsch, @MilhouseVH Latest changes can be followed in my repository in this branch. Consequently this PR will be closed. |
| @@ -233,7 +233,7 @@ bool CActiveAEBufferPoolResample::Create(unsigned int totaltime, bool remap, boo | |||
| if (m_processor->GetChannelLayout().Count() > 2) /* Disable upmix for CActiveAEResample if DSP layout > 2.0, becomes perfomed by DSP */ | |||
| upmix = false; | |||
|
|
|||
| m_dspBuffer = new CActiveAEBufferPool(m_inputFormat); /* Get dsp processing buffer class, based on dsp output format */ | |||
| m_dspBuffer = new CActiveAEBufferPool(m_format); /* Get dsp processing buffer class, based on dsp output format */ | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Jenkins seems to be happy about my changes. So far only XCode is missing because I don't own a Mac. Is there someone who can do the required changes. I moved the entire source code of AudioDSP from |
|
i am on it ... why is this pr closed? |
|
@AchimTuran something is wrong - the branch from this PR has not the mentioned changes - nothing to fix for me ... |
@FernetMenta @popcornmix @MilhouseVH @AlwinEsch @fritsch
These are fixes to prevent Kodi crashing when adsp is enabled on RPi and probably Android (it's currently not tested from my side). I don't know why this has worked before on Windows, Linux and OS X because the speaker layout and buffer sizes could be wrong in some cases.
I already tested these fixes on Windows and it's fine.
But currently I stock, all video frames are dropped and I don't know why. Maybe adsp does something wrong with the picture time stamp. So it would be nice if @AlwinEsch, @FernetMenta or @fritsch could have a look at it.