Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail to Removing Physical NIC #246

Merged
merged 2 commits into from Nov 13, 2023
Merged

Conversation

ajpri
Copy link
Contributor

@ajpri ajpri commented Nov 13, 2023

Added some detail to the remove physical NIC section. Based on personal experience removing a NIC for the first time in my Home Lab, adding some verbosity might assist other users like myself.

Before submitting the pull request, you must agree with the following statements by checking both boxes with a 'x'.

  • "I accept that my contribution is placed under the CC BY-SA 2.0 license [1]."
  • "My contribution complies with the Developer Certificate of Origin [2]."

[1] https://creativecommons.org/licenses/by-sa/2.0/
[2] https://docs.xcp-ng.org/project/contributing/#developer-certificate-of-origin-dco

Signed-off-by: Austin Pritchett austin@pritchett.info

Added some detail to the remove physical NIC section. 

Signed-off-by: AJ <austin@pritchett.info>
Copy link
Member

@olivierlambert olivierlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Only very minor changes to do 👍

docs/networking/networking.md Outdated Show resolved Hide resolved
docs/networking/networking.md Outdated Show resolved Hide resolved
added missing space and adjust language on after boot. 

Signed-off-by: AJ <austin@pritchett.info>
@olivierlambert olivierlambert merged commit 8b91919 into xcp-ng:master Nov 13, 2023
1 check passed
@ajpri ajpri deleted the patch-1 branch November 13, 2023 18:49
@olivierlambert
Copy link
Member

Your change is now available: https://docs.xcp-ng.org/networking/#remove-a-physical-nic

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants