Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index for screenshots in HTML report #343

Closed
wants to merge 1 commit into from
Closed

Fix index for screenshots in HTML report #343

wants to merge 1 commit into from

Conversation

mkj-is
Copy link

@mkj-is mkj-is commented Nov 9, 2018

The enlarging of screenshots does not work correctly if there were more screenshots taken in one test. Opening any screenshot will enlarge the first one, since wrong index (which is always zero) is used.

This PR should fix the issue.

I am not sure how to test the template, since this is JS and HTML issue so writing simple behavior test would be pretty hard.

Illustrative image

@mkj-is
Copy link
Author

mkj-is commented Feb 27, 2019

The test failed due to slow execution, I believe this is due to flakiness of this test. The change made in the pull request should not influence anything.

Then the performance should be way faster than running cat # features/steps/xcpretty_steps.rb:27
      XCPretty run time: 2.013216262
expected: < 2
      got:   2.013216262 (RSpec::Expectations::ExpectationNotMetError)

@mkj-is
Copy link
Author

mkj-is commented Nov 11, 2019

Closing this one due to no response from code owners.

@mkj-is mkj-is closed this Nov 11, 2019
@mkj-is mkj-is deleted the fix-screenshot-enlarging-in-html-report branch November 11, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant