Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only last configured Identifier is published via xcube serve #589

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

TonioF
Copy link
Contributor

@TonioF TonioF commented Jan 19, 2022

Solves #576 .

Checklist:

  • Add unit tests and/or doctests in docstrings
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions
  • [ ] New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@TonioF TonioF requested a review from forman January 19, 2022 10:42
@TonioF TonioF self-assigned this Jan 19, 2022
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy :)

CHANGES.md Outdated Show resolved Hide resolved
@@ -300,6 +300,7 @@ def get_dataset_configs_from_stores(self) \
if fnmatch.fnmatch(store_dataset_id,
dataset_id_pattern):
dataset_config_base = store_dataset_config
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha!

Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
@TonioF TonioF merged commit 5038797 into master Jan 19, 2022
@TonioF TonioF deleted the toniof-576-last_identifier branch January 19, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants