Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.9 segfaults during tests #264

Closed
Licenser opened this issue Oct 6, 2019 · 6 comments
Closed

v0.9 segfaults during tests #264

Licenser opened this issue Oct 6, 2019 · 6 comments

Comments

@Licenser
Copy link

Licenser commented Oct 6, 2019

After the 0.9 release tarpaulin started to segfault when running tests:
@Licenser Licenser mentioned this issue Oct 6, 2019
Merged
@rye
Copy link
Contributor

rye commented Oct 6, 2019

Same here: https://github.com/rye/rust-netaddr2/runs/249317332

@xd009642
Copy link
Owner

xd009642 commented Oct 6, 2019

Ah cripes. You should be able to revert to the old behaviour by adding -- --test-threads=1 to the end of your command to run tarpaulin

@elinorbgr elinorbgr mentioned this issue Oct 6, 2019
Closed
@Licenser
Copy link
Author

Licenser commented Oct 6, 2019

👍 can confirm -- --test-threads=1 solved the issue :D for us! thanks!

brycx added a commit to orion-rs/orion that referenced this issue Oct 6, 2019
@brycx
CI: Workaround for tarpaulin segfault (xd009642/tarpaulin#264)
0ca4035
EFanZh added a commit to EFanZh/Introduction-to-Algorithms that referenced this issue Oct 13, 2019
@EFanZh
Fix coverage segfault
8f39692 
xd009642/tarpaulin#264.
rye added a commit to rye/rust-netaddr2 that referenced this issue Oct 20, 2019
@rye
ci: Use --test-threads=1 to prevent a segfault
0d17e11 
[GitHub] See also xd009642/tarpaulin#264.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
rye added a commit to rye/motion-planning that referenced this issue Oct 20, 2019
@rye
ci: Use --test-threads=1 to prevent a segfault
5ca9c27 
[GitHub] See also xd009642/tarpaulin#264.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@baszalmstra baszalmstra mentioned this issue Oct 21, 2019
Merged
baszalmstra added a commit to mun-lang/mun that referenced this issue Oct 21, 2019
@baszalmstra
fix(ci): Use --test-threads=1 to prevent a segfault (#21)
82271fc 
See also xd009642/tarpaulin#264. Should probably revert this once tarpaulin is fixed.
@baszalmstra baszalmstra mentioned this issue Oct 22, 2019
Closed
@xd009642
Copy link
Owner

This may be fixed in the 0.9.1 release which is in the process of being built and pushed to crates.io via github actions

rye added a commit to rye/rust-netaddr2 that referenced this issue Oct 31, 2019
@rye
ci: Remove the --test-threads=1 argument
892c946 
It appears that version 0.9.1 has been released, which might fix the
execution in parallel causing segmentation faults.

See xd009642/tarpaulin#264 for the discussion
about this issue.

I will test this and see if it works!

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
rye added a commit to rye/git-heckout that referenced this issue Oct 31, 2019
@rye
ci: Remove --test-threads=1
d45c0e3 
It seems to no longer be needed, per the new release of tarpaulin that
seems to resolve xd009642/tarpaulin#264.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
rye added a commit to rye/motion-planning that referenced this issue Oct 31, 2019
@rye
ci: Remove --test-threads=1
cc831ef 
It seems to no longer be needed, per the new release of tarpaulin that
seems to resolve xd009642/tarpaulin#264.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@Licenser
Copy link
Author

Licenser commented Nov 1, 2019

Can confirm it's fixed on my end :) happy to close if no one else has objections

@xd009642
Copy link
Owner

xd009642 commented Nov 2, 2019

Closing any new segfaults etc open a new issue as this one has already covered two causes no need to grow it further :)

@xd009642 xd009642 closed this as completed Nov 2, 2019
EFanZh added a commit to EFanZh/Introduction-to-Algorithms that referenced this issue Feb 18, 2023
@EFanZh
Fix coverage segfault
6089582 
xd009642/tarpaulin#264.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Licenser @rye @xd009642